Re: [PATCH] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside mmap_pgoff

From	Matthew Wilcox <willy@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside mmap_pgoff
Date	2017-04-04 14:10 +0200
Message-ID	<tsvrz-4G7-7@gated-at.bofh.it> (permalink)
References	<tsoJs-8um-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 04, 2017 at 10:26:35AM +0530, Anshuman Khandual wrote:
> The commit 091d0d55b286 ("shm: fix null pointer deref when userspace
> specifies invalid hugepage size") had replaced MAP_HUGE_MASK with
> SHM_HUGE_MASK. Though both of them contain the same numeric value of
> 0x3f, MAP_HUGE_MASK flag sounds more appropriate than the other one
> in the context. Hence change it back.
> 
> Acked-by: Balbir Singh <bsingharora@gmail.com>
> Acked-by: Michal Hocko <mhocko@suse.com>
> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>

Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>

We had a more extensive version of this last week ...

https://lkml.org/lkml/2017/3/28/1005

I'm fine with this minor fix going in by itself.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside mmap_pgoff Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-04-04 07:00 +0200
  Re: [PATCH] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside  mmap_pgoff Matthew Wilcox <willy@infradead.org> - 2017-04-04 14:10 +0200

csiph-web