Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1615784
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V7 4/7] mfd: da9061: MFD core support |
| Date | 2017-04-04 10:40 +0200 |
| Message-ID | <tssam-2oD-9@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <tq0UW-12M-37@gated-at.bofh.it> <tsaZR-7XD-47@gated-at.bofh.it> <tsb9x-80W-45@gated-at.bofh.it> <tsbjc-84l-17@gated-at.bofh.it> <tscyC-nv-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 03 Apr 2017, Steve Twiss wrote:
> On 03 April 2017 15:31, Lee Jones wrote:
>
> > Subject: Re: [PATCH V7 4/7] mfd: da9061: MFD core support
> >
> > On Mon, 03 Apr 2017, Steve Twiss wrote:
> > > On 03 April 2017 15:12, Lee Jones wrote:
> > >
> > > > > @@ -475,7 +855,25 @@ static int da9062_i2c_probe(struct i2c_client *i2c,
> > > > > return -EINVAL;
> > > > > }
> > > > >
> > > > > - chip->regmap = devm_regmap_init_i2c(i2c, &da9062_regmap_config);
> > > > > + switch (chip->chip_type) {
> > > > > + case(COMPAT_TYPE_DA9061):
> > > >
> > > > Brackets around the case value?
> > > >
> > > > That's a new one on me.
> > >
> > > Hm. Do you want me to resend it without braces?
> >
> > Yes please. And a space after the 'case'.
>
> Hi Lee,
>
> I have resent PATCH V7 to change "case(X):" to be "case X:".
> - Removed brackets surrounding case statements for
> case COMPAT_TYPE_DA9061:
> case COMPAT_TYPE_DA9062:
Okay, good.
> New patch is here:
> https://lkml.org/lkml/2017/4/3/462
>
> The patch it is called by the same title "[PATCH V7 4/7] mfd: da9061: MFD core support".
> I've not updated the whole patch-set or changed the patch version number from V7.
I don't see it in my inbox?
You should always change the version, or things get confusing.
Even if it's a small change, you can differentiate by v7.1 or similar.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V7 0/7] da9061: DA9061 driver submission Steve Twiss <stwiss.opensource@diasemi.com> - 2017-03-28 17:10 +0200
[PATCH V7 6/7] thermal: da9062/61: Thermal junction temperature monitoring driver Steve Twiss <stwiss.opensource@diasemi.com> - 2017-03-28 17:10 +0200
Re: [PATCH V7 6/7] thermal: da9062/61: Thermal junction temperature monitoring driver Eduardo Valentin <edubezval@gmail.com> - 2017-04-01 22:00 +0200
RE: [PATCH V7 6/7] thermal: da9062/61: Thermal junction temperature monitoring driver Steve Twiss <stwiss.opensource@diasemi.com> - 2017-04-03 15:30 +0200
[PATCH V7 1/7] Documentation: devicetree: watchdog: da9062/61 watchdog timer binding Steve Twiss <stwiss.opensource@diasemi.com> - 2017-03-28 17:10 +0200
[PATCH V7 5/7] regulator: da9061: BUCK and LDO regulator driver Steve Twiss <stwiss.opensource@diasemi.com> - 2017-03-28 17:10 +0200
[PATCH V7 2/7] Documentation: devicetree: thermal: da9062/61 TJUNC temperature binding Steve Twiss <stwiss.opensource@diasemi.com> - 2017-03-28 17:10 +0200
[PATCH V7 4/7] mfd: da9061: MFD core support Steve Twiss <stwiss.opensource@diasemi.com> - 2017-03-28 17:10 +0200
Re: [PATCH V7 4/7] mfd: da9061: MFD core support Lee Jones <lee.jones@linaro.org> - 2017-04-03 16:20 +0200
RE: [PATCH V7 4/7] mfd: da9061: MFD core support Steve Twiss <stwiss.opensource@diasemi.com> - 2017-04-03 16:30 +0200
Re: [PATCH V7 4/7] mfd: da9061: MFD core support Lee Jones <lee.jones@linaro.org> - 2017-04-03 16:40 +0200
RE: [PATCH V7 4/7] mfd: da9061: MFD core support Steve Twiss <stwiss.opensource@diasemi.com> - 2017-04-03 18:00 +0200
Re: [PATCH V7 4/7] mfd: da9061: MFD core support Lee Jones <lee.jones@linaro.org> - 2017-04-04 10:40 +0200
Re: [PATCH V7 0/7] da9061: DA9061 driver submission Eduardo Valentin <edubezval@gmail.com> - 2017-04-07 07:00 +0200
csiph-web