Re: [PATCH] selftests: add a generic testsuite for ethernet device

From	Corentin Labbe <clabbe.montjoie@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] selftests: add a generic testsuite for ethernet device
Date	2017-04-04 10:00 +0200
Message-ID	<tsrxE-1Uf-11@gated-at.bofh.it> (permalink)
References	<tr4tr-52J-11@gated-at.bofh.it> <tr4tr-52J-9@gated-at.bofh.it> <tr5zc-5Hc-11@gated-at.bofh.it> <tsa3M-7m2-19@gated-at.bofh.it> <tsadr-7pt-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 03, 2017 at 03:27:41PM +0200, Andrew Lunn wrote:
> > By ifnum, you mean by the order that "ip link" gives ?
> 
> I've not checked if it remains in order as interfaces are hot
> plugged/unplugged. But i guess you are running tests direct after
> boot, and unplugs/replugs are unlikely?
> 

Yes the ideal run is just after boot, but the test need to succeed in all case.

For handling vlan, I think the best way is to detect the master interface by looking the "@master".
So when testing a vlan interface, the test would just up also the masteri interface.

So I will drop using "ls /sys/clas/net/" and directly use output of ip

Regards

Thread

[PATCH] selftests: add a generic testsuite for ethernet device Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-03-31 15:10 +0200
  Re: [PATCH] selftests: add a generic testsuite for ethernet device Andrew Lunn <andrew@lunn.ch> - 2017-03-31 16:20 +0200
    Re: [PATCH] selftests: add a generic testsuite for ethernet device Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-03 15:20 +0200
      Re: [PATCH] selftests: add a generic testsuite for ethernet device Andrew Lunn <andrew@lunn.ch> - 2017-04-03 15:30 +0200
        Re: [PATCH] selftests: add a generic testsuite for ethernet device Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-04 10:00 +0200
          Re: [PATCH] selftests: add a generic testsuite for ethernet device Andrew Lunn <andrew@lunn.ch> - 2017-04-04 14:30 +0200

csiph-web