Re: [PATCH 4/7] bio-integrity: fix interface for bio_integrity_trim

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/7] bio-integrity: fix interface for bio_integrity_trim
Date	2017-04-04 09:10 +0200
Message-ID	<tsqLg-1B3-31@gated-at.bofh.it> (permalink)
References	<ts4B4-3Mv-5@gated-at.bofh.it> <ts4B4-3Mv-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 03, 2017 at 11:23:29AM +0400, Dmitry Monakhov wrote:
> bio_integrity_trim inherent it's interface from bio_trim and accept
> offset and size, but this API is error prone because data offset
> must always be insync with bio's data offset. That is why we have
> integrity update hook in bio_advance()
> 
> So only meaningful offset is 0. Let's just remove it completely.

I think we can get rid of size as well and derive it from the bio,
can't we?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/7] bio-integrity: fix interface for bio_integrity_trim Dmitry Monakhov <dmonakhov@openvz.org> - 2017-04-03 09:30 +0200
  Re: [PATCH 4/7] bio-integrity: fix interface for bio_integrity_trim Christoph Hellwig <hch@infradead.org> - 2017-04-04 09:10 +0200

csiph-web