Re: [PATCH 5/7] bio-integrity: add bio_integrity_setup helper

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/7] bio-integrity: add bio_integrity_setup helper
Date	2017-04-04 09:10 +0200
Message-ID	<tsqLf-1B3-17@gated-at.bofh.it> (permalink)
References	<ts4B4-3Mv-5@gated-at.bofh.it> <ts4B4-3Mv-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 03, 2017 at 11:23:30AM +0400, Dmitry Monakhov wrote:
> Currently all integrity prep hooks are open-coded, and if prepare fails
> we ignore it's code and fail bio with EIO. Let's return real error to
> upper layer, so later caller may react accordingly. For example retry in
> case of ENOMEM.

bio_integrity_enabled and bio_integrity_prep seem to be unused outside
of  bio_integrity_setup, so they can be removed / folded into
bio_integrity_setup.  Which at this point might just keep the
bio_integrity_prep name to fit into the blocking traditions :)

Also please update Documentation/block/data-integrity.txt for your
changes and add a kerneldoc comment for the new function.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 5/7] bio-integrity: add bio_integrity_setup helper Dmitry Monakhov <dmonakhov@openvz.org> - 2017-04-03 09:30 +0200
  Re: [PATCH 5/7] bio-integrity: add bio_integrity_setup helper Christoph Hellwig <hch@infradead.org> - 2017-04-04 09:10 +0200

csiph-web