Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1615697

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Vivek,

[auto build test WARNING on balbi-usb/next]
[also build test WARNING on v4.11-rc5 next-20170403]
[cannot apply to pza/reset/next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vivek-Gautam/reset-APIs-to-manage-a-list-of-resets/20170404-111639
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-x008-201714 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/reset/core.c: In function 'reset_control_array_deassert':
   drivers/reset/core.c:526:2: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
     for (i = 0; i < num_rsts; i++)
     ^~~
   drivers/reset/core.c:528:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'for'
      if (ret)
      ^~
>> drivers/reset/core.c:531:9: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
     return 0;
            ^

vim +/ret +531 drivers/reset/core.c

   520	{
   521		int ret, i;
   522	
   523		if (WARN_ON(IS_ERR_OR_NULL(resets)))
   524			return -EINVAL;
   525	
 > 526		for (i = 0; i < num_rsts; i++)
   527			ret = reset_control_deassert(resets[i].rst);
   528			if (ret)
   529				goto err;
   530	
 > 531		return 0;
   532	
   533	err:
   534		while (--i >= 0)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] reset: APIs to manage a list of resets Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-04-03 15:50 +0200
  [PATCH v2 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-04-03 15:50 +0200
  [PATCH v2 2/4] reset: Add APIs to manage array of resets Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-04-03 15:50 +0200
    Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-03 18:40 +0200
      Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-04-04 12:50 +0200
        Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-04 14:50 +0200
          Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-04-05 09:00 +0200
    Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets kbuild test robot <lkp@intel.com> - 2017-04-04 06:20 +0200
  [PATCH v2 3/4] usb: dwc3: of-simple: Add support to get resets for the device Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-04-03 15:50 +0200
    [PATCH] usb: dwc3: of-simple: fix noderef.cocci warnings kbuild test robot <lkp@intel.com> - 2017-04-04 07:30 +0200
    Re: [PATCH v2 3/4] usb: dwc3: of-simple: Add support to get resets  for the device kbuild test robot <lkp@intel.com> - 2017-04-04 07:30 +0200

csiph-web