Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1615659

Re: [PATCH net-next v4 1/2] New kernel function to get IP overhead on a socket.

Show all headers | View raw

Hi Dave,

Please see inline:

On Mon, 3 Apr 2017, David Miller wrote:

> From: "R. Parameswaran" <parameswaran.r7@gmail.com>
> Date: Mon, 3 Apr 2017 13:28:11 -0700 (PDT)
> 
> > Can I take this to mean that we do need to factor in IP options in 
> > the L2TP device MTU setup (i.e approach in the posted patch is okay)? 
> > 
> > If yes, please let me know if I can keep the socket IP option overhead 
> > calculations in a generic function, or it would be better to move it back into 
> > L2TP code? 
> 
> If the user creates and maintains this UDP socket, then yes we have to
> account for potential IP options.
> 

Can I take this to mean that the patch in its present form is 
acceptable (patch currently accounts for IP options on the socket)? 
Please let me know if any further change is needed (I'll clean up the 
krobot reported errors after this).

thanks,

Ramkumar

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH net-next v4 1/2] New kernel function to get IP overhead  on a socket. "R. Parameswaran" <parameswaran.r7@gmail.com> - 2017-04-03 22:30 +0200
  Re: [PATCH net-next v4 1/2] New kernel function to get IP overhead  on a socket. David Miller <davem@davemloft.net> - 2017-04-03 22:40 +0200
    Re: [PATCH net-next v4 1/2] New kernel function to get IP overhead  on a socket. David Miller <davem@davemloft.net> - 2017-04-04 04:20 +0200
    Re: [PATCH net-next v4 1/2] New kernel function to get IP overhead  on a socket. "R. Parameswaran" <parameswaran.r7@gmail.com> - 2017-04-04 04:20 +0200

csiph-web