Re: [PATCH 11/11] platform/x86: fujitsu-laptop: remove redundant fields from struct fujitsu_bl

From	Darren Hart <dvhart@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/11] platform/x86: fujitsu-laptop: remove redundant fields from struct fujitsu_bl
Date	2017-04-04 03:20 +0200
Message-ID	<tslix-6h9-7@gated-at.bofh.it> (permalink)
References	<tqFEK-4YK-7@gated-at.bofh.it> <tqFEK-4YK-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 30, 2017 at 12:35:09PM +0200, Michał Kępień wrote:
> The dev field of struct fujitsu_bl is assigned in acpi_fujitsu_bl_add(),
> but never used afterwards.  brightness_changed is set in get_lcd_level()
> and then its value is only printed in a debug message, so it does not
> influence execution flow.  Remove both fields as they are redundant.

Indeed, once that was removed from the platform device and the corresponding
sysfs entries were eliminated, we can drop it:

78b2602 platform/x86: fujitsu-laptop: remove backlight-related attributes from the platform device

:-)

-- 
Darren Hart
VMware Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 11/11] platform/x86: fujitsu-laptop: remove redundant fields from struct fujitsu_bl Michał Kępień <kernel@kempniu.pl> - 2017-03-30 12:40 +0200
  Re: [PATCH 11/11] platform/x86: fujitsu-laptop: remove redundant  fields from struct fujitsu_bl Darren Hart <dvhart@infradead.org> - 2017-04-04 03:20 +0200

csiph-web