Re: [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927 Amplifier

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927 Amplifier
Date	Mon, 03 Apr 2017 18:40:02 +0200
Message-ID	<tsdbk-RK-37@gated-at.bofh.it> (permalink)
References	<tsdbk-RK-39@gated-at.bofh.it>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DeRGBSCpUMH+v99JCD5eAVLFhcDB+4zqwggqMUWzyHc=; b=pDD5R5ZdktrIO3PiT8lJQo6ZrTMmGer4bi5yTl+nBu36FpvxwmAEeMp6vP9Y5Qwiqy +rYXjq8jj8GuvwLLBMTFz1+ci893Bffj0Gxlw9mI8LtfhKJh44HYRMaNelrB9CLB12/M 7wabfivz68ZGU+ckgBy5OdEu37vw5z53etG2Jq+cyjseowPq9v6B5MwPKnUV4BEQQUu8 dwJmY1njcbB0mNxy6sDZz074aJz9LeuDnhIPcRIU9h+dFpmyT0MZNqbNeFQydxFRB0gH Wr/69qgC2BY23so2WOrr9hD1KnYAfhDyIJfCJl32x5EjxGDtvyGhNf1Z8U3vZH99mUS2 Vs3A==
X-Gm-Message-State	AFeK/H0DQHAzNlRiuVv4fmeDkSuSSCYdcMBumyCXbOTW5uhzIqyxd2nEdilrZUkdMczFCw==
X-Received	by 10.157.1.134 with SMTP id e6mr8925801ote.168.1491237054291; Mon, 03 Apr 2017 09:30:54 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.6.2-neo (2016-08-21)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	44
Organization	linux.* mail to news gateway
X-Original-Cc	lgirdwood@gmail.com, broonie@kernel.org, mark.rutland@arm.com, perex@perex.cz, tiwai@suse.com, kuninori.morimoto.gx@renesas.com, arnd@arndb.de, ckeepax@opensource.wolfsonmicro.com, lars@metafoo.de, bardliao@realtek.com, nh6z@nh6z.net, KCHSU0@nuvoton.com, axel.lin@ingics.com, romain.perier@collabora.com, srinivas.kandagatla@linaro.org, oder_chiou@realtek.com, Paul.Handrigan@cirrus.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dgreid@google.com, ryan.lee.maxim@gmail.com
X-Original-Date	Mon, 3 Apr 2017 11:30:53 -0500
X-Original-Message-ID	<20170403163053.u6b3yadkfyh4z7h5@rob-hp-laptop>
X-Original-References	<1490922994-19294-1-git-send-email-ryans.lee@maximintegrated.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1615408

Show key headers only | View raw

On Fri, Mar 31, 2017 at 10:16:34AM +0900, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
> ---
> 
> Changes since v4:
> 	* Removed support for SND_SOC_DAIFMT_CBS_CFM.
> 	* Fixed coding style for indention.
> 	* Removed variables if it has only one user.
> 	* Assigned ch_size directly.
> 	* Removed oring.
> 	* Put the return false in the switch statement.
> 	* Removed 'Monomix Output' and 'Speaker Source' controls.
> 	* Modified control names per control-names.rst.
> 	* Moved Revision ID check code to i2c_probe function.
> 	* Added 'Current Limit' control.
> 	* Removed 'devm__kfree' function.
> 
> Changes since v3:
> 	* Combined MAX98926 and MAX98927 binding. Kept existing property name.

This looks fine, but:
 
> Changes since v2:
> 	* Removed local register read/write function to avoid duplication of ASoC core function.
> 
>  .../devicetree/bindings/sound/max98925.txt         |  22 -
>  .../devicetree/bindings/sound/max98926.txt         |  32 -
>  .../devicetree/bindings/sound/max9892x.txt         |  41 +
>  sound/soc/codecs/Kconfig                           |   5 +
>  sound/soc/codecs/Makefile                          |   2 +
>  sound/soc/codecs/max98927.c                        | 841 +++++++++++++++++++++
>  sound/soc/codecs/max98927.h                        | 272 +++++++
>  7 files changed, 1161 insertions(+), 54 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/max98925.txt
>  delete mode 100644 Documentation/devicetree/bindings/sound/max98926.txt
>  create mode 100755 Documentation/devicetree/bindings/sound/max9892x.txt
>  mode change 100644 => 100755 sound/soc/codecs/Kconfig
>  mode change 100644 => 100755 sound/soc/codecs/Makefile
>  create mode 100755 sound/soc/codecs/max98927.c
>  create mode 100755 sound/soc/codecs/max98927.h

These should all be 644 mode.

Rob

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927  Amplifier Rob Herring <robh@kernel.org> - 2017-04-03 18:40 +0200

csiph-web