[PATCH v2 1/5] mfd: cros-ec: Fix host command buffer size

Path	csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Enric Balletbo i Serra <enric.balletbo@collabora.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 1/5] mfd: cros-ec: Fix host command buffer size
Date	Mon, 03 Apr 2017 18:40:02 +0200
Message-ID	<tsdbk-RK-33@gated-at.bofh.it> (permalink)
References	<tsdbj-RK-5@gated-at.bofh.it>
X-Original-To	Jonathan Cameron <jic23@kernel.org>, Lee Jones <lee.jones@linaro.org>, Olof Johansson <olof@lixom.net>, bleung@chromium.org
X-Mailer	git-send-email 2.9.3
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	martinez.javier@gmail.com, Guenter Roeck <groeck@chromium.org>, Gwendal Grignou <gwendal@chromium.org>, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, rtc-linux@googlegroups.com, Vic Yang <victoryang@google.com>
X-Original-Date	Mon, 3 Apr 2017 18:35:32 +0200
X-Original-Message-ID	<20170403163536.25634-2-enric.balletbo@collabora.com>
X-Original-References	<20170403163536.25634-1-enric.balletbo@collabora.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1615399

Show key headers only | View raw

From: Vic Yang <victoryang@google.com>

For SPI, we can get up to 32 additional bytes for response preamble.
The current overhead (2 bytes) may cause problems when we try to receive
a big response. Update it to 32 bytes.

Without this fix we could see a kernel BUG when we receive a big response
from the Chrome EC when is connected via SPI.

Signed-off-by: Vic Yang <victoryang@google.com>
Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---

  This patch is a FIX, and I think that would be interesting see it merged
in this release cycle. This should go through the MFD tree and can be picked
independently of the other patches. Lee Jones I think this is for you.

Changes since v1:
 - None

 include/linux/mfd/cros_ec.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h
index b3e812f..3b16c90 100644
--- a/include/linux/mfd/cros_ec.h
+++ b/include/linux/mfd/cros_ec.h
@@ -35,10 +35,11 @@
  * Max bus-specific overhead incurred by request/responses.
  * I2C requires 1 additional byte for requests.
  * I2C requires 2 additional bytes for responses.
+ * SPI requires up to 32 additional bytes for responses.
  * */
 #define EC_PROTO_VERSION_UNKNOWN	0
 #define EC_MAX_REQUEST_OVERHEAD		1
-#define EC_MAX_RESPONSE_OVERHEAD	2
+#define EC_MAX_RESPONSE_OVERHEAD	32
 
 /*
  * Command interface between EC and AP, for LPC, I2C and SPI interfaces.
-- 
2.9.3

Thread

[PATCH v2 0/5]  mfd: cros-ec: Some fixes and improvements. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-04-03 18:40 +0200
  [PATCH v2 5/5] mfd: cros_ec: add RTC as mfd subdevice Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-04-03 18:40 +0200
  [PATCH v2 1/5] mfd: cros-ec: Fix host command buffer size Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-04-03 18:40 +0200
  [PATCH v2 2/5] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-04-03 18:40 +0200
  [PATCH v2 3/5] mfd: cros_ec: Introduce RTC commands and events definitions. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-04-03 18:40 +0200
  [PATCH v2 4/5] rtc: cros-ec: add cros-ec-rtc driver. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-04-03 18:40 +0200

csiph-web