Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1615433

Re: [PATCH] ACPICA: use designated initializers

From Kees Cook <keescook@chromium.org>
Newsgroups linux.kernel
Subject Re: [PATCH] ACPICA: use designated initializers
Date 2017-04-03 19:30 +0200
Message-ID <tsdXI-1pB-5@gated-at.bofh.it> (permalink)
References (1 earlier) <sPZj4-42w-3@gated-at.bofh.it> <tqtaz-4hp-45@gated-at.bofh.it> <tqxQR-7M1-7@gated-at.bofh.it> <trf5v-3mz-7@gated-at.bofh.it> <trfoR-3t3-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 31, 2017 at 5:45 PM, Moore, Robert <robert.moore@intel.com> wrote:
> Acpica is built with many compilers, even very old ones. It runs on at least 12 known operating systems, and very probably more.
>
> I'm sorry, but no, we are not going to start adding compiler-specific ifdefs/code in the base ACPICA code.
>
> I don't care what you do in the Linux-specific or gcc-specific headers, however. If this breaks a customer build, we (you) will hear about it rather quickly.

Since the change is specific to the one place ACPICA uses an
all-function-pointer structure, I made the change local:

https://github.com/acpica/acpica/pull/248

would you rather this is in the .h files instead?

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ACPICA: use designated initializers Kees Cook <keescook@chromium.org> - 2017-03-29 23:20 +0200
  RE: [PATCH] ACPICA: use designated initializers "Zheng, Lv" <lv.zheng@intel.com> - 2017-03-30 04:20 +0200
    RE: [PATCH] ACPICA: use designated initializers "Moore, Robert" <robert.moore@intel.com> - 2017-03-30 16:30 +0200
    Re: [PATCH] ACPICA: use designated initializers Kees Cook <keescook@chromium.org> - 2017-04-01 02:30 +0200
      RE: [PATCH] ACPICA: use designated initializers "Moore, Robert" <robert.moore@intel.com> - 2017-04-01 02:50 +0200
        Re: [PATCH] ACPICA: use designated initializers Kees Cook <keescook@chromium.org> - 2017-04-03 19:30 +0200
          RE: [PATCH] ACPICA: use designated initializers "Moore, Robert" <robert.moore@intel.com> - 2017-04-04 17:10 +0200
            Re: [PATCH] ACPICA: use designated initializers Kees Cook <keescook@chromium.org> - 2017-04-04 18:00 +0200

csiph-web