Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1615250

Re: [PATCH 2/2] drivers/serial: Add driver for Aspeed virtual UART

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] drivers/serial: Add driver for Aspeed virtual UART
Date 2017-04-03 16:30 +0200
Message-ID <tsb9x-80W-39@gated-at.bofh.it> (permalink)
References <tpSaZ-332-3@gated-at.bofh.it> <tpSaZ-332-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Mar 28, 2017 at 04:14:58PM +1030, Joel Stanley wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
> 
> This change adds a driver for the 16550-based Aspeed virtual UART
> device. We use a similar process to the of_serial driver for device
> probe, but expose some VUART-specific functions through sysfs too.
> 
> OpenPOWER host firmware doesn't like it when the host-side of the
> VUART's FIFO is not drained. This driver only disables host TX discard
> mode when the port is in use. We set the VUART enabled bit when we bind
> to the device, and clear it on unbind.
> 
> We don't want to do this on open/release, as the host may be using this
> bit to configure serial output modes, which is independent of whether
> the devices has been opened by BMC userspace.
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>  Documentation/devicetree/bindings/serial/8250.txt |   2 +

For the binding:

Acked-by: Rob Herring <robh@kernel.org>

>  drivers/tty/serial/Kconfig                        |  10 +
>  drivers/tty/serial/Makefile                       |   1 +
>  drivers/tty/serial/aspeed-vuart.c                 | 335 ++++++++++++++++++++++
>  4 files changed, 348 insertions(+)
>  create mode 100644 drivers/tty/serial/aspeed-vuart.c

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] drivers/serial: Add driver for Aspeed virtual UART Joel Stanley <joel@jms.id.au> - 2017-03-28 07:50 +0200
  Re: [PATCH 2/2] drivers/serial: Add driver for Aspeed virtual UART Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-31 15:40 +0200
    Re: [PATCH 2/2] drivers/serial: Add driver for Aspeed virtual UART Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-03-31 23:40 +0200
  Re: [PATCH 2/2] drivers/serial: Add driver for Aspeed virtual UART Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-02 15:10 +0200
    Re: [PATCH 2/2] drivers/serial: Add driver for Aspeed virtual UART Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-04-02 23:20 +0200
    Re: [PATCH 2/2] drivers/serial: Add driver for Aspeed virtual UART Joel Stanley <joel@jms.id.au> - 2017-04-03 09:20 +0200
  Re: [PATCH 2/2] drivers/serial: Add driver for Aspeed virtual UART Rob Herring <robh@kernel.org> - 2017-04-03 16:30 +0200

csiph-web