[PATCH] crypto: arm64/sha: use %c constraint code in ASM_EXPORT

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Matthias Kaehlcke <mka@chromium.org>
Newsgroups	linux.kernel
Subject	[PATCH] crypto: arm64/sha: use %c constraint code in ASM_EXPORT
Date	Wed, 05 Apr 2017 19:00:01 +0200
Message-ID	<tsWrL-57A-1@gated-at.bofh.it> (permalink)
X-Original-To	Ard Biesheuvel <ard.biesheuvel@linaro.org>, Greg Hackmann <ghackmann@google.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S . Miller" <davem@davemloft.net>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2IsENTkS6wi+KRrKUESUz1FyswFUBoXcWSXxZgSSnpk=; b=pjvpiTWHlviDBX/urkxSTSmzl4TLx3nZZj6wMgOKO5WEQi85RGANk2yoXuBfgO3ZrJ tPkazSdfKw2jp7xS/2S2Z8q6DMvFscxch3IFQz9ZZnizyhvwYEqjvshQUqTwAQJ93APn C6hrpRBZ1ef7pLTESn4V7V2lh+jcyUwoLIR4ca7lNHerDmZsWUMt80l9rb+uakHiWwmb JSAknq2aKOMk1A2MRisqOX9AqVci/KQXF/QCImVGfHLVmEFABqSmoF4ajIj3RPVDNlN4 u8ILAw1+ktrD8ePDEmOUVWCyneN2zNA3eU+e7nYcf2p5g0JyLnfn/7cLaevzcTT/9D/z 379Q==
X-Gm-Message-State	AFeK/H3t2P9tkYsDdcwgt3jCqo2auG/kOs9mvUPkLvao7LNx6RqaBP9qb3NHeWV8CVAFIcEx
X-Received	by 10.99.247.69 with SMTP id f5mr32006644pgk.63.1491411394475; Wed, 05 Apr 2017 09:56:34 -0700 (PDT)
X-Mailer	git-send-email 2.12.2.715.g7642488e1d-goog
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	44
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Grant Grundler <grundler@chromium.org>, Michael Davidson <md@google.com>, Matthias Kaehlcke <mka@chromium.org>
X-Original-Date	Wed, 5 Apr 2017 09:56:03 -0700
X-Original-Message-ID	<20170405165603.87264-1-mka@chromium.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1617139

Show key headers only | View raw

From: Greg Hackmann <ghackmann@google.com>

The current definition of ASM_EXPORT doesn't work properly with clang,
according to https://bugs.llvm.org//show_bug.cgi?id=27250#c3 it relies on
gcc specific behavior. Change the constraint from an intermediate to an
output expression which works with both gcc and clang.

From: Greg Hackmann <ghackmann@google.com>
Commit-message-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Greg Hackmann <ghackmann@google.com>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
 arch/arm64/crypto/sha1-ce-glue.c | 2 +-
 arch/arm64/crypto/sha2-ce-glue.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/crypto/sha1-ce-glue.c b/arch/arm64/crypto/sha1-ce-glue.c
index aefda9868627..c71e94ba0e43 100644
--- a/arch/arm64/crypto/sha1-ce-glue.c
+++ b/arch/arm64/crypto/sha1-ce-glue.c
@@ -18,7 +18,7 @@
 #include <linux/module.h>
 
 #define ASM_EXPORT(sym, val) \
-	asm(".globl " #sym "; .set " #sym ", %0" :: "I"(val));
+	asm(".globl " #sym "; .set " #sym ", %c0" :: "I"(val));
 
 MODULE_DESCRIPTION("SHA1 secure hash using ARMv8 Crypto Extensions");
 MODULE_AUTHOR("Ard Biesheuvel <ard.biesheuvel@linaro.org>");
diff --git a/arch/arm64/crypto/sha2-ce-glue.c b/arch/arm64/crypto/sha2-ce-glue.c
index 7cd587564a41..381b5fb2dcb2 100644
--- a/arch/arm64/crypto/sha2-ce-glue.c
+++ b/arch/arm64/crypto/sha2-ce-glue.c
@@ -18,7 +18,7 @@
 #include <linux/module.h>
 
 #define ASM_EXPORT(sym, val) \
-	asm(".globl " #sym "; .set " #sym ", %0" :: "I"(val));
+	asm(".globl " #sym "; .set " #sym ", %c0" :: "I"(val));
 
 MODULE_DESCRIPTION("SHA-224/SHA-256 secure hash using ARMv8 Crypto Extensions");
 MODULE_AUTHOR("Ard Biesheuvel <ard.biesheuvel@linaro.org>");
-- 
2.12.2.715.g7642488e1d-goog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] crypto: arm64/sha: use %c constraint code in ASM_EXPORT Matthias Kaehlcke <mka@chromium.org> - 2017-04-05 19:00 +0200
  Re: [PATCH] crypto: arm64/sha: use %c constraint code in ASM_EXPORT Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-04-05 19:10 +0200
    Re: [PATCH] crypto: arm64/sha: use %c constraint code in ASM_EXPORT Robin Murphy <robin.murphy@arm.com> - 2017-04-05 19:30 +0200
      Re: [PATCH] crypto: arm64/sha: use %c constraint code in ASM_EXPORT Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-04-05 19:50 +0200
    Re: [PATCH] crypto: arm64/sha: use %c constraint code in ASM_EXPORT Matthias Kaehlcke <mka@chromium.org> - 2017-04-05 19:50 +0200

csiph-web