Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1617222
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers |
| Date | 2017-04-05 19:30 +0200 |
| Message-ID | <tsWUP-5zn-29@gated-at.bofh.it> (permalink) |
| References | <tsTtU-3hW-43@gated-at.bofh.it> <tsTtU-3hW-41@gated-at.bofh.it> <tsUzD-3Vt-3@gated-at.bofh.it> <tsWi6-54x-25@gated-at.bofh.it> <tsWBu-5sA-81@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Apr 05, 2017 at 05:06:19PM +0000, Ghannam, Yazen wrote:
> Checking if we have a valid deferred error. Since we call __log_error() on
> thresholding interrupts too we would need to tell it which handler is calling
> it to do the correct check. This is what we currently do.
That's why I suggested a __log_error_deferred() - a separate function
which deals with deferred errors.
> What do you mean " we don't have anything"? We check if we have a valid
> deferred error in is_deferred_error(). Otherwise, we don't log anything.
So the normal status MSR says whether we have a deferred error or not.
If it says we don't, then we have to look at the DE* MSRs, correct?
If yes, then do it exactly like this.
Not:
IF deferred:
log
ELSE IF SMCA:
IF deferred:
log
but:
IF deferred:
log_deferred:
log
IF cannot log from normal MSRs
log from DE
Why are we even wasting time with this?!
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers Borislav Petkov <bp@alien8.de> - 2017-04-05 15:50 +0200
RE: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers "Ghannam, Yazen" <Yazen.Ghannam@amd.com> - 2017-04-05 17:00 +0200
Re: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers Borislav Petkov <bp@alien8.de> - 2017-04-05 18:50 +0200
RE: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers "Ghannam, Yazen" <Yazen.Ghannam@amd.com> - 2017-04-05 19:10 +0200
Re: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers Borislav Petkov <bp@alien8.de> - 2017-04-05 19:30 +0200
RE: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers "Ghannam, Yazen" <Yazen.Ghannam@amd.com> - 2017-04-05 20:20 +0200
Re: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers Borislav Petkov <bp@alien8.de> - 2017-04-05 20:30 +0200
RE: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers "Ghannam, Yazen" <Yazen.Ghannam@amd.com> - 2017-04-05 21:40 +0200
Re: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers Borislav Petkov <bp@alien8.de> - 2017-04-05 22:20 +0200
RE: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers "Ghannam, Yazen" <Yazen.Ghannam@amd.com> - 2017-04-07 22:40 +0200
Re: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR} registers Borislav Petkov <bp@alien8.de> - 2017-04-07 23:40 +0200
csiph-web