Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port

From	Ralph Sennhauser <ralph.sennhauser@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port
Date	2017-04-05 18:10 +0200
Message-ID	<tsVFp-4Pz-37@gated-at.bofh.it> (permalink)
References	<tsLG1-6OS-5@gated-at.bofh.it> <tsUgj-3Nd-31@gated-at.bofh.it> <tsV2G-4nq-13@gated-at.bofh.it> <tsVvI-4x0-17@gated-at.bofh.it>
Organization	none

Show all headers | View raw

Hi Andrew,

On Wed, 5 Apr 2017 17:50:32 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> > In fact "internet" label on the case is uppercase, would this matter
> > for you for new bindings, or would you still use the lowercase
> > version?  
> 
> I would use lower case, just to fix with the general convention that
> interface names are lower case.

Thanks

> 
> > > I would say, this is now too late. Changing an interface name will
> > > break configuration scripts. We are stuck with it.
> > >   
> > 
> > If it weren't for commit cb4f71c42988 that would have been obvious
> > for me as well.  
> 
> Yes, that was not nice. But it was also very earlier in the life of
> 38x, so it just affected a few developers with reference boards, not
> real products out in the wild, as far as i remember.
> 
>      Andrew

The mentioned commit bit me amongst others, see
https://lkml.org/lkml/2016/8/21/62

In fact I expect the impact to be much lower this time around, before
4.10 DSA was no contender for swconfig (out of tree switch driver as
used by OpenWrt and others). On Mamba ~200Mbit was top speed. Now they
perform roughly the same.


Thanks
Ralph

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-04-05 07:30 +0200
  Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead  of internet for DSA port Andrew Lunn <andrew@lunn.ch> - 2017-04-05 16:40 +0200
    Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead  of internet for DSA port Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-04-05 17:30 +0200
      Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead  of internet for DSA port Andrew Lunn <andrew@lunn.ch> - 2017-04-05 18:00 +0200
        Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead  of internet for DSA port Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-04-05 18:10 +0200

csiph-web