Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1617015

Re: [PATCH 1/4] dt-bindings: iio: stm32-dac: Add support for STM32 DAC

Show all headers | View raw

On 04/02/2017 01:16 PM, Jonathan Cameron wrote:
> On 31/03/17 12:45, Fabrice Gasnier wrote:
>> Document STMicroelectronics STM32 DAC (digital-to-analog converter).
>>
>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
>> ---
>>  .../devicetree/bindings/iio/dac/st,stm32-dac.txt   | 56 ++++++++++++++++++++++
>>  1 file changed, 56 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/iio/dac/st,stm32-dac.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/dac/st,stm32-dac.txt b/Documentation/devicetree/bindings/iio/dac/st,stm32-dac.txt
>> new file mode 100644
>> index 0000000..1981983
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/dac/st,stm32-dac.txt
>> @@ -0,0 +1,56 @@
>> +STMicroelectronics STM32 DAC
>> +
>> +The STM32 DAC is a 12-bit voltage output digital-to-analog converter. The DAC
>> +can be configured in 8- or 12-bit mode. In 12-bit mode, the data could be
>> +left- or right-aligned.
> Whilst possibly true, do we care about the alignment?  That'll all get wrapped
> up in the driver.
Hi Jonathan,

I'll update this description in V2

> 
>> It has two output channels, each with its own converter.
>> +It has built-in noise and triangle waveform generator and supports external
>> +triggers for conversions. The DAC's output buffer allows a high drive output
>> +current.
> Ah.. This is going to be fun :) More unusual hardware to find in an SoC.
Yes, let's discuss this on following patches.

Thanks your review,
Best Regards,
Fabrice

>> +
>> +Contents of a stm32 dac root node:
>> +-----------------------------------
>> +Required properties:
>> +- compatible: Must be "st,stm32h7-dac-core".
>> +- reg: Offset and length of the device's register set.
>> +- clocks: Must contain an entry for pclk (which feeds the peripheral bus
>> +  interface)
>> +- clock-names: Must be "pclk".
>> +- vref-supply: Phandle to the vref+ input analog reference supply.
>> +
>> +Optional properties:
>> +- resets: Must contain the phandle to the reset controller.
>> +- A pinctrl state named "default" for each DAC channel may be defined to set
>> +  DAC_OUTx pin in mode of operation for analog output on external pin.
>> +
>> +Contents of a stm32 dac child node:
>> +-----------------------------------
>> +DAC core node should contain at least one subnode, representing a
>> +DAC instance/channel available on the machine.
>> +
>> +Required properties:
>> +- compatible: Must be "st,stm32-dac".
>> +- #io-channel-cells = <1>: See the IIO bindings section "IIO consumers" in
>> +  Documentation/devicetree/bindings/iio/iio-bindings.txt
>> +- st,dac-channel: Must be either 1 or 2, to define channel in use (e.g.
>> +  single channels: 1 or 2)
>> +
>> +Example:
>> +	dac: dac@40007400 {
>> +		compatible = "st,stm32h7-dac-core";
>> +		reg = <0x40007400 0x400>;
>> +		clocks = <&clk>;
>> +		clock-names = "pclk";
>> +		vref-supply = <&reg_vref>;
>> +
>> +		dac1: dac@1 {
>> +			compatible = "st,stm32-dac";
>> +			#io-channels-cells = <1>;
>> +			st,dac-channel = <1>;
>> +		};
>> +
>> +		dac2: dac@2 {
>> +			compatible = "st,stm32-dac";
>> +			#io-channels-cells = <1>;
>> +			st,dac-channel = <2>;
>> +		};
>> +	};
>>
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] Add STM32H7 DAC driver Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-03-31 13:50 +0200
  [PATCH 3/4] iio: dac: stm32: add support for trigger events Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-03-31 13:50 +0200
    Re: [PATCH 3/4] iio: dac: stm32: add support for trigger events Jonathan Cameron <jic23@kernel.org> - 2017-04-02 13:50 +0200
      Re: [PATCH 3/4] iio: dac: stm32: add support for trigger events Jonathan Cameron <jic23@kernel.org> - 2017-04-02 14:30 +0200
        Re: [PATCH 3/4] iio: dac: stm32: add support for trigger events Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-04-05 18:50 +0200
          Re: [PATCH 3/4] iio: dac: stm32: add support for trigger events Jonathan Cameron <jic23@kernel.org> - 2017-04-08 19:20 +0200
  [PATCH 1/4] dt-bindings: iio: stm32-dac: Add support for STM32 DAC Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-03-31 13:50 +0200
    Re: [PATCH 1/4] dt-bindings: iio: stm32-dac: Add support for STM32  DAC Jonathan Cameron <jic23@kernel.org> - 2017-04-02 13:20 +0200
      Re: [PATCH 1/4] dt-bindings: iio: stm32-dac: Add support for STM32  DAC Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-04-05 16:50 +0200
    Re: [PATCH 1/4] dt-bindings: iio: stm32-dac: Add support for STM32  DAC Rob Herring <robh@kernel.org> - 2017-04-03 18:50 +0200
      Re: [PATCH 1/4] dt-bindings: iio: stm32-dac: Add support for STM32  DAC Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-04-05 16:50 +0200
  [PATCH 2/4] iio: dac: add support for stm32 DAC Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-03-31 13:50 +0200
    Re: [PATCH 2/4] iio: dac: add support for stm32 DAC Peter Meerwald-Stadler <pmeerw@pmeerw.net> - 2017-04-01 14:40 +0200
      Re: [PATCH 2/4] iio: dac: add support for stm32 DAC Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-04-05 17:00 +0200
    Re: [PATCH 2/4] iio: dac: add support for stm32 DAC Jonathan Cameron <jic23@kernel.org> - 2017-04-02 13:40 +0200
      Re: [PATCH 2/4] iio: dac: add support for stm32 DAC Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-04-05 17:50 +0200
        Re: [PATCH 2/4] iio: dac: add support for stm32 DAC Jonathan Cameron <jic23@kernel.org> - 2017-04-08 19:20 +0200

csiph-web