Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1617041
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Yuval Shaia <yuval.shaia@oracle.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/5] IB/qib: Use kcalloc() in qib_init_iba7322_funcs() |
| Date | Wed, 05 Apr 2017 17:20:02 +0200 |
| Message-ID | <tsUT0-4j0-17@gated-at.bofh.it> (permalink) |
| References | <tsTDz-3ln-1@gated-at.bofh.it> <tsTDz-3ln-7@gated-at.bofh.it> <tsUgi-3Nd-19@gated-at.bofh.it> <tsUzD-3Vt-7@gated-at.bofh.it> <tsUJk-4eA-25@gated-at.bofh.it> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=iso-8859-1 |
| Content-Disposition | inline |
| Content-Transfer-Encoding | 8bit |
| User-Agent | Mutt/1.5.24 (2015-08-30) |
| X-Source-IP | userv0021.oracle.com [156.151.31.71] |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 31 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | SF Markus Elfring <elfring@users.sourceforge.net>, linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>, Hal Rosenstock <hal.rosenstock@gmail.com>, Mike Marciniszyn <infinipath@intel.com>, Sean Hefty <sean.hefty@intel.com>, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org |
| X-Original-Date | Wed, 5 Apr 2017 18:17:48 +0300 |
| X-Original-Message-ID | <20170405151747.GB5519@yuval-lap> |
| X-Original-References | <c16b18ac-287f-5faf-b79a-c86e2adfa22c@users.sourceforge.net> <5e5e00d3-b6a4-7371-65be-c5fe387d26b3@users.sourceforge.net> <20170405143438.GC5006@yuval-lap> <fa90e815-daff-57b1-7930-447c6f5fa3ab@users.sourceforge.net> <20170405150658.GU3941@linux-x5ow.site> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1617041 |
Show key headers only | View raw
On Wed, Apr 05, 2017 at 05:06:58PM +0200, Johannes Thumshirn wrote: > On Wed, Apr 05, 2017 at 04:54:40PM +0200, SF Markus Elfring wrote: > > >> @@ -7324,8 +7324,9 @@ struct qib_devdata *qib_init_iba7322_funcs(struct pci_dev *pdev, > > >> actual_cnt -= dd->num_pports; > > >> > > >> tabsize = actual_cnt; > > >> - dd->cspec->msix_entries = kzalloc(tabsize * > > >> - sizeof(struct qib_msix_entry), GFP_KERNEL); > > >> + dd->cspec->msix_entries = kcalloc(tabsize, > > >> + sizeof(*dd->cspec->msix_entries), > > >> + GFP_KERNEL); > > > > > > Are we fine with loosing the zeroing of the entries? > > > > How did you get this concern? > > > > Do you really miss such functionality from the other interface? > > Ahm... Don't kzalloc() and kcalloc() both pass in __GFP_ZERO? Yes. Please ignore my comment. > > -- > Johannes Thumshirn Storage > jthumshirn@suse.de +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/5] IB/qib: Fine-tuning for four function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-05 16:00 +0200
[PATCH 2/5] IB/qib: Use kmalloc_array() in qib_init_7322_variables() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-05 16:00 +0200
Re: [PATCH 2/5] IB/qib: Use kmalloc_array() in qib_init_7322_variables() Yuval Shaia <yuval.shaia@oracle.com> - 2017-04-05 16:30 +0200
[PATCH 1/5] IB/qib: Use kcalloc() in qib_init_iba7322_funcs() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-05 16:00 +0200
Re: [PATCH 1/5] IB/qib: Use kcalloc() in qib_init_iba7322_funcs() Yuval Shaia <yuval.shaia@oracle.com> - 2017-04-05 16:40 +0200
Re: [PATCH 1/5] IB/qib: Use kcalloc() in qib_init_iba7322_funcs() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-05 17:00 +0200
Re: [PATCH 1/5] IB/qib: Use kcalloc() in qib_init_iba7322_funcs() Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-05 17:10 +0200
Re: [PATCH 1/5] IB/qib: Use kcalloc() in qib_init_iba7322_funcs() Yuval Shaia <yuval.shaia@oracle.com> - 2017-04-05 17:20 +0200
[PATCH 3/5] IB/qib: Use kcalloc() in qib_alloc_devdata() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-05 16:00 +0200
[PATCH 4/5] IB/qib: Use kcalloc() in qib_init_pportdata() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-05 16:00 +0200
[PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-05 16:10 +0200
Re: [PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata() Yuval Shaia <yuval.shaia@oracle.com> - 2017-04-05 16:40 +0200
Re: [PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-05 17:10 +0200
Re: [PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata() Yuval Shaia <yuval.shaia@oracle.com> - 2017-04-05 17:20 +0200
Re: IB/qib: Adjust two size determinations in qib_init_pportdata() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-05 17:30 +0200
Re: IB/qib: Adjust two size determinations in qib_init_pportdata() Yuval Shaia <yuval.shaia@oracle.com> - 2017-04-06 21:50 +0200
Re: IB/qib: Adjust two size determinations in qib_init_pportdata() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-06 22:40 +0200
Re: [PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata() Bart Van Assche <Bart.VanAssche@sandisk.com> - 2017-04-05 17:20 +0200
Re: [PATCH 0/5] IB/qib: Fine-tuning for four function implementations Dennis Dalessandro <dennis.dalessandro@intel.com> - 2017-04-06 02:40 +0200
csiph-web