Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1616993

Re: [PATCH] net: ibm: emac: remove unused sysrq handler for 'c' key

Show all headers | View raw

From: Eric Biggers <ebiggers3@gmail.com>
Date: Mon,  3 Apr 2017 22:50:20 -0700

> From: Eric Biggers <ebiggers@google.com>
> 
> Since commit d6580a9f1523 ("kexec: sysrq: simplify sysrq-c handler"),
> the sysrq handler for the 'c' key has been sysrq_crash_op.  Debugging
> code in the ibm_emac driver also tries to register a handler for the 'c'
> key, but this has no effect because register_sysrq_key() doesn't replace
> existing handlers.  Since evidently no one has cared enough to fix this
> in the last 8 years, and it's very rare for drivers to register sysrq
> handlers (for good reason), just remove the dead code.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Applied to net-next, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: ibm: emac: remove unused sysrq handler for 'c' key Eric Biggers <ebiggers3@gmail.com> - 2017-04-04 08:00 +0200
  Re: [PATCH] net: ibm: emac: remove unused sysrq handler for 'c' key David Miller <davem@davemloft.net> - 2017-04-05 16:30 +0200

csiph-web