Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1616902

Re: [1/2] mwifiex: fix use-after-free for FW reinit errors

Show all headers | View raw

Brian Norris <briannorris@chromium.org> wrote:
> If we fail to reinit the FW when resetting the device (in the
> synchronous version of mwifiex_init_hw_fw() -> mwifiex_fw_dpc()),
> mwifiex_fw_dpc() will tear down the interface and free up the adapter.
> But we don't actually check for all failure cases of mwifiex_fw_dpc(),
> so some of them fall through and dereference adapter->fw_done with a
> freed adapter, causing a use-after-free bug.
> 
> In any case, mwifiex_fw_dpc() will always signal FW completion -- in the
> error OR success case -- so at best, this was repeat work. Let's not do
> it.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

2 patches applied to wireless-drivers-next.git, thanks.

ce8fad9a1f09 mwifiex: fix use-after-free for FW reinit errors
755b37c93a06 mwifiex: catch mwifiex_fw_dpc() errors properly in reset

-- 
https://patchwork.kernel.org/patch/9650725/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] mwifiex: fix use-after-free for FW reinit errors Brian Norris <briannorris@chromium.org> - 2017-03-29 02:10 +0200
  [PATCH 2/2] mwifiex: catch mwifiex_fw_dpc() errors properly in reset Brian Norris <briannorris@chromium.org> - 2017-03-29 02:10 +0200
  Re: [1/2] mwifiex: fix use-after-free for FW reinit errors Kalle Valo <kvalo@codeaurora.org> - 2017-04-05 14:50 +0200

csiph-web