Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1616678

Re: [PATCH] xen, fbfront: fix connecting to backend

Show all headers | View raw

On 23/03/17 13:52, Juergen Gross wrote:
> Connecting to the backend isn't working reliably in xen-fbfront: in
> case XenbusStateInitWait of the backend has been missed the backend
> transition to XenbusStateConnected will trigger the connected state
> only without doing the actions required when the backend has
> connected.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>

Bartlomiej, any comments? Can you please take this patch or should I
carry it through the Xen tree?


Juergen

> ---
>  drivers/video/fbdev/xen-fbfront.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> index d0115a7..3ee309c 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -643,7 +643,6 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
>  		break;
>  
>  	case XenbusStateInitWait:
> -InitWait:
>  		xenbus_switch_state(dev, XenbusStateConnected);
>  		break;
>  
> @@ -654,7 +653,8 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
>  		 * get Connected twice here.
>  		 */
>  		if (dev->state != XenbusStateConnected)
> -			goto InitWait; /* no InitWait seen yet, fudge it */
> +			/* no InitWait seen yet, fudge it */
> +			xenbus_switch_state(dev, XenbusStateConnected);
>  
>  		if (xenbus_read_unsigned(info->xbdev->otherend,
>  					 "request-update", 0))
> 

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] xen, fbfront: fix connecting to backend Juergen Gross <jgross@suse.com> - 2017-04-05 10:20 +0200
  Re: [PATCH] xen, fbfront: fix connecting to backend Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-04-05 16:50 +0200

csiph-web