Re: [PATCH] loop: Add PF_LESS_THROTTLE to block/loop device thread.

From	Ming Lei <tom.leiming@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] loop: Add PF_LESS_THROTTLE to block/loop device thread.
Date	2017-04-05 07:20 +0200
Message-ID	<tsLwl-6L2-3@gated-at.bofh.it> (permalink)
References	<trYOZ-8pQ-7@gated-at.bofh.it> <tsqUV-1Er-5@gated-at.bofh.it> <tsKJX-6c1-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Apr 5, 2017 at 12:27 PM, NeilBrown <neilb@suse.com> wrote:
> On Tue, Apr 04 2017, Christoph Hellwig wrote:
>
>> Looks fine,
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>>
>> But if you actually care about performance in any way I'd suggest
>> to use the loop device in direct I/O mode..
>
> The losetup on my test VM is too old to support that :-(
> I guess it might be time to upgraded.
>
> It seems that there is not "mount -o direct_loop" or similar, so you
> have to do the losetup and the mount separately.  Any thoughts on

I guess the 'direct_loop' can be added into 'mount' directly? but not familiar
with mount utility.

> whether that should be changed ?

There was sysfs interface for controling direct IO in the initial
submission, but
looks it was reviewed out, :-)


Thanks,
Ming Lei

Thread

[PATCH] loop: Add PF_LESS_THROTTLE to block/loop device thread. NeilBrown <neilb@suse.com> - 2017-04-03 03:20 +0200
  Re: [PATCH] loop: Add PF_LESS_THROTTLE to block/loop device thread. Christoph Hellwig <hch@infradead.org> - 2017-04-04 09:20 +0200
    Re: [PATCH] loop: Add PF_LESS_THROTTLE to block/loop device thread. NeilBrown <neilb@suse.com> - 2017-04-05 06:30 +0200
      Re: [PATCH] loop: Add PF_LESS_THROTTLE to block/loop device thread. Ming Lei <tom.leiming@gmail.com> - 2017-04-05 07:20 +0200
  Re: [PATCH] loop: Add PF_LESS_THROTTLE to block/loop device thread. Michal Hocko <mhocko@kernel.org> - 2017-04-04 13:30 +0200
  Re: [PATCH] loop: Add PF_LESS_THROTTLE to block/loop device thread. Ming Lei <tom.leiming@gmail.com> - 2017-04-04 16:30 +0200
    Re: [PATCH] loop: Add PF_LESS_THROTTLE to block/loop device thread. NeilBrown <neilb@suse.com> - 2017-04-05 06:40 +0200
  [PATCH v2] loop: Add PF_LESS_THROTTLE to block/loop device thread. NeilBrown <neilb@suse.com> - 2017-04-05 06:40 +0200
    Re: [PATCH v2] loop: Add PF_LESS_THROTTLE to block/loop device thread. Ming Lei <tom.leiming@gmail.com> - 2017-04-05 07:10 +0200
    Re: [PATCH v2] loop: Add PF_LESS_THROTTLE to block/loop device  thread. Michal Hocko <mhocko@kernel.org> - 2017-04-05 09:20 +0200
      Re: [PATCH v2] loop: Add PF_LESS_THROTTLE to block/loop device  thread. Michal Hocko <mhocko@kernel.org> - 2017-04-05 09:40 +0200
        Re: [PATCH v2] loop: Add PF_LESS_THROTTLE to block/loop device thread. NeilBrown <neilb@suse.com> - 2017-04-06 04:30 +0200
          Re: [PATCH v2] loop: Add PF_LESS_THROTTLE to block/loop device  thread. Michal Hocko <mhocko@kernel.org> - 2017-04-06 09:00 +0200
            [PATCH v3] loop: Add PF_LESS_THROTTLE to block/loop device thread. NeilBrown <neilb@suse.com> - 2017-04-07 01:50 +0200

csiph-web