Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1616215
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings |
| Date | 2017-04-04 19:10 +0200 |
| Message-ID | <tsA7U-7Nb-23@gated-at.bofh.it> (permalink) |
| References | <tsyIO-6H1-7@gated-at.bofh.it> <tsyIP-6H1-51@gated-at.bofh.it> <tszYd-7uN-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello Rob, On 04/04/2017 12:54 PM, Rob Herring wrote: > On Tue, Apr 4, 2017 at 10:30 AM, Javier Martinez Canillas > <javier@osg.samsung.com> wrote: >> There are Device Tree source files defining a device node for the >> retu/tahvo I2C chip, but there isn't a DT binding document for it. >> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >> >> --- >> >> Changes in v4: >> - Use "dt-bindings: mfd:" prefix in subject line (Rob Herring). >> - Add information about what functions the device serve (Lee Jones). >> - Avoid using MFD in Device Tree (Lee Jones). >> >> Changes in v3: None >> Changes in v2: None >> >> Documentation/devicetree/bindings/mfd/retu.txt | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/retu.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/retu.txt b/Documentation/devicetree/bindings/mfd/retu.txt >> new file mode 100644 >> index 000000000000..7df21a2b28ea >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/retu.txt >> @@ -0,0 +1,21 @@ >> +* Device tree bindings for Nokia Retu and Tahvo multi-function device >> + >> +Retu and Tahvo are a multi-function devices found on Nokia Internet >> +Tablets (770, N800 and N810). The Retu chip provides watchdog timer >> +and power button control functionalities while Tahvo chip provides >> +USB transceiver functionality. >> + >> +Required properties: >> +- compatible: "nokia,retu" or "nokia,tahvo" >> +- reg: Specifies the I2C slave address of the ASIC chip > > Missing interrupts here. > Right, sorry for missing that. I'll wait for Lee's feedback before posting a new version in case I missed something else. > With that: > > Acked-by: Rob Herring <robh@kernel.org> > Thanks a lot for your review and acks! Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-04 17:40 +0200
[PATCH v4 4/8] ARM: dts: n8x0: Add vendor prefix to retu node Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-04 17:40 +0200
[PATCH v4 8/8] ARM: ux500: Add vendor prefix to tps61052 node Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-04 17:40 +0200
[PATCH v4 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-04 17:40 +0200
[PATCH v4 6/8] dt-bindings: mfd: Add TI tps6105x chip bindings Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-04 17:40 +0200
[PATCH v4 3/8] mfd: retu: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-04 17:40 +0200
[PATCH v4 1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-04 17:40 +0200
Re: [PATCH v4 1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings Rob Herring <robh+dt@kernel.org> - 2017-04-04 19:00 +0200
Re: [PATCH v4 1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-04 19:10 +0200
Re: [PATCH v4 0/8] mfd: Add OF device table to I2C drivers that are missing it Rob Herring <robh+dt@kernel.org> - 2017-04-04 19:00 +0200
Re: [PATCH v4 0/8] mfd: Add OF device table to I2C drivers that are missing it Aaro Koskinen <aaro.koskinen@iki.fi> - 2017-04-04 19:40 +0200
Re: [PATCH v4 0/8] mfd: Add OF device table to I2C drivers that are missing it Tony Lindgren <tony@atomide.com> - 2017-04-04 19:50 +0200
Re: [PATCH v4 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-04 19:50 +0200
csiph-web