Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1615149

Re: [PATCH RFC] remove custom Michael MIC implementation

Show all headers | View raw

On Mon, Apr 03, 2017 at 07:03:59PM +1000, Tobin C. Harding wrote:
> On Mon, Apr 03, 2017 at 08:19:40AM +0300, Kalle Valo wrote:
> > + linux-wireless
> > 
> > "Tobin C. Harding" <me@tobin.cc> writes:
> > 
> > > On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote:
> > >> 
> > >> > The code is untested, I have hardware in the mail.
> > >> 
> > >> Cool!
> > >
> > > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is
> > > a SDW-823 and should use the ks7010 driver. I am going to attempt to
> > > get it running on a Raspberry Pi B+. I ordered the wrong size break
> > > out board originally so waiting on the new one now.
> > >
> > >> 
> > >> > If any one is interested and has any comments I would really like to
> > >> > hear them. I am open to all suggestions (even down to trivial coding
> > >> > style issues).
> > >> 
> > >> I'll just repeat that the key move to get this driver out of staging is
> > >> to get away from the WEXT interface to CFG80211. Otherwise no chance
> > >> that wireless maintainers will even look at it. This is a huge change
> > >> but once it is done, features like Michael MIC come with it for free
> > >> (from what I recall, I am not a wireless expert myself).
> > >
> > > That would explain why I could not find more than the Orinoco driver
> > > using the Michael MIC module directly.
> > 
> > I think cfg80211 and mac80211 got mixed up. mac80211 (the full IEEE
> > 802.11 stack for "softmac" devices) provides Michael MIC implementation,
> > but cfg80211 (for "hardmac" devices) does not.
> 
> Cool, thanks for clarifying. Hilariously I was just sitting down
> trying to figure out what was up after a day spent trying to merge
> ideas from ath6kl (fullmac) and ks7010. I finally spent some time
> reading the cw1200 driver (softmac) for further inspiration.

As an example of a driver that has been moved from an internal wireless
stack to using the kernel stack is the vt6655 driver.  I think it's the
only driver that has done this type of transition, so look at the patch
history of it for an example of what to do.

good luck!

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RFC] remove custom Michael MIC implementation "Tobin C. Harding" <me@tobin.cc> - 2017-03-31 06:50 +0200
  Re: [PATCH RFC] remove custom Michael MIC implementation Wolfram Sang <wsa@the-dreams.de> - 2017-03-31 10:00 +0200
    Re: [PATCH RFC] remove custom Michael MIC implementation "Tobin C. Harding" <me@tobin.cc> - 2017-03-31 12:30 +0200
      Re: [PATCH RFC] remove custom Michael MIC implementation Wolfram Sang <wsa@the-dreams.de> - 2017-03-31 12:50 +0200
        Re: [PATCH RFC] remove custom Michael MIC implementation "Tobin C. Harding" <me@tobin.cc> - 2017-04-01 12:50 +0200
      Re: [PATCH RFC] remove custom Michael MIC implementation Kalle Valo <kvalo@codeaurora.org> - 2017-04-03 07:30 +0200
        Re: [PATCH RFC] remove custom Michael MIC implementation "Tobin C. Harding" <me@tobin.cc> - 2017-04-03 11:10 +0200
          Re: [PATCH RFC] remove custom Michael MIC implementation Kalle Valo <kvalo@codeaurora.org> - 2017-04-03 12:00 +0200
          Re: [PATCH RFC] remove custom Michael MIC implementation Toke Høiland-Jørgensen <toke@toke.dk> - 2017-04-03 12:10 +0200
            Re: [PATCH RFC] remove custom Michael MIC implementation Arend Van Spriel <arend.vanspriel@broadcom.com> - 2017-04-03 12:20 +0200
              Re: [PATCH RFC] remove custom Michael MIC implementation "Tobin C. Harding" <me@tobin.cc> - 2017-04-03 23:40 +0200
                Re: [PATCH RFC] remove custom Michael MIC implementation Arend Van Spriel <arend.vanspriel@broadcom.com> - 2017-04-04 23:40 +0200
                Re: [PATCH RFC] remove custom Michael MIC implementation "Tobin C. Harding" <me@tobin.cc> - 2017-04-05 03:20 +0200
          Re: [PATCH RFC] remove custom Michael MIC implementation Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-03 14:20 +0200

csiph-web