Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1615143

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

From Denys Fedoryshchenko <nuclearcat@nuclearcat.com>
Newsgroups linux.kernel
Subject Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8
Date 2017-04-03 14:20 +0200
Message-ID <ts97I-6L2-5@gated-at.bofh.it> (permalink)
References (7 earlier) <trR18-30F-5@gated-at.bofh.it> <trRkt-3oq-1@gated-at.bofh.it> <trRua-3sA-17@gated-at.bofh.it> <ts5ns-4l0-19@gated-at.bofh.it> <ts8Y4-6GK-69@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 2017-04-03 15:09, Eric Dumazet wrote:
> On Mon, 2017-04-03 at 11:10 +0300, Denys Fedoryshchenko wrote:
> 
>> I modified patch a little as:
>> if (th->doff * 4 < sizeof(_tcph)) {
>>   par->hotdrop = true;
>>   WARN_ON_ONCE(!tcpinfo->option);
>>   return false;
>> }
>> 
>> And it did triggered WARN once at morning, and didn't hit KASAN. I 
>> will
>> run for a while more, to see if it is ok, and then if stable, will try
>> to enable SFQ again.
> 
> Excellent news !
> We will post an official fix today, thanks a lot for this detective 
> work
> Denys.
I am not sure it is finally fixed, maybe we need test more?
I'm doing extensive tests today with identical configuration (i had to 
run fifo, because customer cannot afford anymore outages). I've dded sfq 
now different way, and identical config i will run after 3 hours approx.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Denys Fedoryshchenko <nuclearcat@nuclearcat.com> - 2017-04-02 09:50 +0200
  Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Eric Dumazet <eric.dumazet@gmail.com> - 2017-04-02 13:30 +0200
    Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Florian Westphal <fw@strlen.de> - 2017-04-02 13:50 +0200
      Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Denys Fedoryshchenko <nuclearcat@nuclearcat.com> - 2017-04-02 14:00 +0200
      Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Eric Dumazet <eric.dumazet@gmail.com> - 2017-04-02 14:00 +0200
        Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Eric Dumazet <eric.dumazet@gmail.com> - 2017-04-02 14:30 +0200
          Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Denys Fedoryshchenko <nuclearcat@nuclearcat.com> - 2017-04-02 14:30 +0200
            Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Eric Dumazet <eric.dumazet@gmail.com> - 2017-04-02 14:40 +0200
              Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Denys Fedoryshchenko <nuclearcat@nuclearcat.com> - 2017-04-02 19:00 +0200
                Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Eric Dumazet <eric.dumazet@gmail.com> - 2017-04-02 19:20 +0200
                Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Eric Dumazet <eric.dumazet@gmail.com> - 2017-04-02 19:30 +0200
                Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Denys Fedoryshchenko <nuclearcat@nuclearcat.com> - 2017-04-03 10:20 +0200
                Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Eric Dumazet <eric.dumazet@gmail.com> - 2017-04-03 14:10 +0200
                Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Denys Fedoryshchenko <nuclearcat@nuclearcat.com> - 2017-04-03 14:20 +0200
                Re: KASAN, xt_TCPMSS  finally found nasty use-after-free bug? 4.10.8 Eric Dumazet <eric.dumazet@gmail.com> - 2017-04-03 14:30 +0200

csiph-web