Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1615107

Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table

Show all headers | View raw

On Sat, 01 Apr 2017, Javier Martinez Canillas wrote:

> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
> 
> But this could change in the future so the correct approach is to have a
> OF device ID table if the devices are registered via OF.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
> Changes in v3:
> - Add a vendor prefix to the compatible string (Rob Herring).
> 
> Changes in v2:
> - Don't use of_match_ptr() to avoid build warning when CONFIG_OF is disabled.
> 
>  drivers/mfd/retu-mfd.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/mfd/retu-mfd.c b/drivers/mfd/retu-mfd.c
> index d4c114abeb75..937a1c21eec4 100644
> --- a/drivers/mfd/retu-mfd.c
> +++ b/drivers/mfd/retu-mfd.c
> @@ -308,9 +308,17 @@ static const struct i2c_device_id retu_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, retu_id);
>  
> +static const struct of_device_id retu_of_match[] = {
> +	{ .compatible = "nokia,retu-mfd" },
> +	{ .compatible = "nokia,tahvo-mfd" },

Please drop the "-mfd".

> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, retu_of_match);
> +
>  static struct i2c_driver retu_driver = {
>  	.driver		= {
>  		.name = "retu-mfd",
> +		.of_match_table = retu_of_match,
>  	},
>  	.probe		= retu_probe,
>  	.remove		= retu_remove,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/7] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-01 09:20 +0200
  [PATCH v3 5/7] mfd: Add Device Tree bindings document for TI tps6105x chip Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-01 09:20 +0200
    Re: [PATCH v3 5/7] mfd: Add Device Tree bindings document for TI  tps6105x chip Lee Jones <lee.jones@linaro.org> - 2017-04-03 13:20 +0200
      Re: [PATCH v3 5/7] mfd: Add Device Tree bindings document for TI  tps6105x chip Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-03 17:50 +0200
        Re: [PATCH v3 5/7] mfd: Add Device Tree bindings document for TI  tps6105x chip Lee Jones <lee.jones@linaro.org> - 2017-04-04 10:30 +0200
          Re: [PATCH v3 5/7] mfd: Add Device Tree bindings document for TI  tps6105x chip Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-04 13:50 +0200
  [PATCH v3 3/7] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-01 09:20 +0200
  [PATCH v3 2/7] mfd: retu: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-01 09:30 +0200
    Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table Lee Jones <lee.jones@linaro.org> - 2017-04-03 13:20 +0200
      Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-03 17:50 +0200
        Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table Rob Herring <robh@kernel.org> - 2017-04-04 00:30 +0200
          Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-04 00:30 +0200
            Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table Tony Lindgren <tony@atomide.com> - 2017-04-04 01:00 +0200
              Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-04 01:10 +0200
            Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table Aaro Koskinen <aaro.koskinen@iki.fi> - 2017-04-04 01:10 +0200
  [PATCH v3 4/7] ARM: dts: n8x0: Add vendor prefix to retu node Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-01 09:30 +0200
  [PATCH v3 7/7] ARM: ux500: Add vendor prefix to tps61052 node Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-01 09:30 +0200

csiph-web