Re: [PATCH 2/2] drm: virtio: fix virtio_gpu_mode_dumb_create

From	Gerd Hoffmann <kraxel@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] drm: virtio: fix virtio_gpu_mode_dumb_create
Date	2017-04-03 11:10 +0200
Message-ID	<ts69P-4Te-3@gated-at.bofh.it> (permalink)
References	<ts4hH-3FM-5@gated-at.bofh.it> <ts4hH-3FM-3@gated-at.bofh.it> <ts546-3XB-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mo, 2017-04-03 at 09:53 +0200, Daniel Vetter wrote:
> On Mon, Apr 03, 2017 at 09:08:45AM +0200, Gerd Hoffmann wrote:
> > Lookup format using virtio_gpu_translate_format()
> > instead of hardcoding it.  Fixes xorg display on
> > bigendian guests (i.e. ppc64).
> > 
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> ow ... :(
> 
> With what kind of client have you tested this? fbdev? kms native?

text console (fbcon) is fine, xorg (modesetting driver) fails.

> Should we patch drm_fourcc.h and essentially state that _all_ drm_fourcc
> are in native endian, don't dare mixing things up?

Well, I don't think this needs clarification.  I never assumed that
fourcc is something else than native endian.  It really was just an
oversight in the virtio driver.

One code path (which creates the framebuffer for fbdev emulation) did
proper drm_fourcc -> virtio format mapping, including endianness
handling.  Patch 1/2 of this series factors this code out into a helper
function so we can easily reuse it.

The other code path (for creating dumb buffers) had the virtio format
hardcoded which happened to work correctly in the little endian case.

cheers,
  Gerd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] drm: virtio: fix virtio_gpu_mode_dumb_create Gerd Hoffmann <kraxel@redhat.com> - 2017-04-03 09:10 +0200
  Re: [PATCH 2/2] drm: virtio: fix virtio_gpu_mode_dumb_create Dave Airlie <airlied@gmail.com> - 2017-04-03 09:50 +0200
  Re: [PATCH 2/2] drm: virtio: fix virtio_gpu_mode_dumb_create Daniel Vetter <daniel@ffwll.ch> - 2017-04-03 10:00 +0200
    Re: [PATCH 2/2] drm: virtio: fix virtio_gpu_mode_dumb_create Gerd Hoffmann <kraxel@redhat.com> - 2017-04-03 11:10 +0200

csiph-web