Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1614864

Re: [PATCH] net: ethernet: ti: cpsw: wake tx queues on ndo_tx_timeout

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] net: ethernet: ti: cpsw: wake tx queues on ndo_tx_timeout
Date Mon, 03 Apr 2017 04:50:01 +0200
Message-ID <ts0e5-Sj-1@gated-at.bofh.it> (permalink)
References <tresO-2Rp-3@gated-at.bofh.it>
X-Original-To grygorii.strashko@ti.com
X-Mailer Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO)
MIME-Version 1.0
Content-Type Text/Plain; charset=us-ascii
Content-Transfer-Encoding 7bit
X-Greylist Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 02 Apr 2017 19:01:51 -0700 (PDT)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 15
Organization linux.* mail to news gateway
X-Original-Cc netdev@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, ivan.khoronzhuk@linaro.org
X-Original-Date Sun, 02 Apr 2017 19:43:06 -0700 (PDT)
X-Original-Message-ID <20170402.194306.1830349337879774492.davem@davemloft.net>
X-Original-References <20170331234123.15607-1-grygorii.strashko@ti.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1614864

Show key headers only | View raw


From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Fri, 31 Mar 2017 18:41:23 -0500

> In case, if TX watchdog is fired some or all netdev TX queues will be
> stopped and as part of recovery it is required not only to drain and
> reinitailize CPSW TX channeles, but also wake up stoppted TX queues what
> doesn't happen now and netdevice will stop transmiting data until
> reopenned.
> 
> Hence, add netif_tx_wake_all_queues() call in .ndo_tx_timeout() to complete
> recovery and restore TX path.
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Applied, thank you.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] net: ethernet: ti: cpsw: wake tx queues on ndo_tx_timeout Grygorii Strashko <grygorii.strashko@ti.com> - 2017-04-01 01:50 +0200
  Re: [PATCH] net: ethernet: ti: cpsw: wake tx queues on  ndo_tx_timeout David Miller <davem@davemloft.net> - 2017-04-03 04:50 +0200

csiph-web