Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1614544

Re: [PATCH 1/8] i2c: export i2c_client_type structure

From Wolfram Sang <wsa@the-dreams.de>
Newsgroups linux.kernel
Subject Re: [PATCH 1/8] i2c: export i2c_client_type structure
Date 2017-04-01 18:10 +0200
Message-ID <trtLc-53x-13@gated-at.bofh.it> (permalink)
References <tjezD-2W7-9@gated-at.bofh.it> <tjezE-2W7-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Mar 09, 2017 at 02:16:37PM -0800, Dmitry Torokhov wrote:
> i2c bus has 2 different types of device belonging to the same bus and
> bus notifiers use device type to distinguish between adapters and clients.
> Previously we only had i2c_adapter_type exported, which made code wanting
> to work with i2c_client devices test for type not equal to adapter type.
> This unfortunately is not safe if we ever add another type to the bus,
> so let's export i2c_client_type as well.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> 
> Wolfram, this is the patch I was talking about in the other mail.

Reviewed-by: Wolfram Sang <wsa@the-dreams.de>

You can add the above tag to all patches in your branch
'4.11-rc3-i2c-irq-resources' and after that we declare it immutable and
I'll pull it into my for-next. Sorry for the delay. I got side-tracked
and ill. But I am better now.

And to keep your heads up: We agreed yesterday that i2c_drivers will get
a flag to signal I2C core to skip all the irq assignment stuff and let
the driver do it itself [1]. Maybe this will become useful for you, too.

[1] http://www.spinics.net/lists/linux-acpi/msg73197.html

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH 1/8] i2c: export i2c_client_type structure Wolfram Sang <wsa@the-dreams.de> - 2017-04-01 18:10 +0200
  Re: [PATCH 1/8] i2c: export i2c_client_type structure Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-04-01 18:50 +0200

csiph-web