[PATCH 3.16 08/19] atm: iphase: fix misleading indention

From	Ben Hutchings <ben@decadent.org.uk>
Newsgroups	linux.kernel
Subject	[PATCH 3.16 08/19] atm: iphase: fix misleading indention
Date	2017-04-01 15:30 +0200
Message-ID	<trrgl-3fN-1@gated-at.bofh.it> (permalink)
References	<trrgm-3fN-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

3.16.43-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Tillmann Heidsieck <theidsieck@leenox.de>

commit cbb41b91e68a302087762823136c9067138cff7c upstream.

Fix a smatch warning:
drivers/atm/iphase.c:1178 rx_pkt() warn: curly braces intended?

The code is correct, the indention is misleading. In case the allocation
of skb fails, we want to skip to the end.

Signed-off-by: Tillmann Heidsieck <theidsieck@leenox.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>
---
 drivers/atm/iphase.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -1175,7 +1175,7 @@ static int rx_pkt(struct atm_dev *dev)
         if (!(skb = atm_alloc_charge(vcc, len, GFP_ATOMIC))) {
            if (vcc->vci < 32)
               printk("Drop control packets\n");
-	      goto out_free_desc;
+	   goto out_free_desc;
         }
 	skb_put(skb,len);  
         // pwang_test

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 3.16 08/19] atm: iphase: fix misleading indention Ben Hutchings <ben@decadent.org.uk> - 2017-04-01 15:30 +0200

csiph-web