Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614502

Re: [PATCH] ipv4: netfilter: Comparison to NULL could be written

Show all headers | View raw

On Sat, 2017-04-01 at 14:05 +0530, Arushi Singhal wrote:
> Fixed coding style for null comparisons to be more
> consistant with the rest of the kernel coding style.

typo: consistent and trivia:

> diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
[]
> @@ -653,7 +653,7 @@ static struct xt_counters *alloc_counters(const struct xt_table *table)
>  	countersize = sizeof(struct xt_counters) * private->number;
>  	counters = vzalloc(countersize);
>  
> -	if (counters == NULL)
> +	if (!counters)
>  		return ERR_PTR(-ENOMEM);

This could also remove the blank link above the test.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ipv4: netfilter: Comparison to NULL could be written Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-04-01 10:40 +0200
  Re: [PATCH] ipv4: netfilter: Comparison to NULL could be written Joe Perches <joe@perches.com> - 2017-04-01 15:10 +0200

csiph-web