Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1614358
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] dm ioctl: Remove double parentheses |
| Date | 2017-04-01 04:10 +0200 |
| Message-ID | <trgEh-4BY-3@gated-at.bofh.it> (permalink) |
| References | <tlGL9-14c-41@gated-at.bofh.it> <trguC-4hQ-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 2017-03-31 at 18:50 -0700, Matthias Kaehlcke wrote:
> El Thu, Mar 16, 2017 at 09:48:30AM -0700 Matthias Kaehlcke ha dit:
>
> > The extra pair of parantheses is not needed and causes clang to generate
> > the following warning:
> >
> > drivers/md/dm-ioctl.c:1776:11: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
> > if ((cmd == DM_DEV_CREATE_CMD)) {
> > ~~~~^~~~~~~~~~~~~~~~~~~~
> > drivers/md/dm-ioctl.c:1776:11: note: remove extraneous parentheses around the comparison to silence this warning
> > if ((cmd == DM_DEV_CREATE_CMD)) {
> > ~ ^ ~
> > drivers/md/dm-ioctl.c:1776:11: note: use '=' to turn this equality comparison into an assignment
> > if ((cmd == DM_DEV_CREATE_CMD)) {
There are dozens of these comparisons in the kernel.
Are you fixing them all or just this one?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] dm ioctl: Remove double parentheses Matthias Kaehlcke <mka@chromium.org> - 2017-04-01 04:00 +0200
Re: [PATCH] dm ioctl: Remove double parentheses Joe Perches <joe@perches.com> - 2017-04-01 04:10 +0200
Re: [PATCH] dm ioctl: Remove double parentheses Matthias Kaehlcke <mka@chromium.org> - 2017-04-03 19:00 +0200
csiph-web