Re: [PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning

From	Randy Dunlap <rdunlap@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning
Date	2017-04-01 00:00 +0200
Message-ID	<trcKm-1KJ-7@gated-at.bofh.it> (permalink)
References	<trbOi-19y-5@gated-at.bofh.it> <trbOi-19y-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/31/17 13:58, Chewie Lin wrote:
> Replace string with formatted arguments in the dev_warn() call. It removes
> the checkpatch warning.

Tell us what the warning was.
and then see if the patch fixes that warning.

> Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
> ---
>  drivers/staging/vt6656/main_usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 9e074e9..2d9e7af 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
>  	status = usb_reset_device(priv->usb);
>  	if (status)
>  		dev_warn(&priv->usb->dev,
> -			 "usb_device_reset fail status=%d\n", status);
> +			 "%s=%d\n", "usb_device_reset fail status", status);
>  }
>  
>  static void vnt_free_int_bufs(struct vnt_private *priv)
> 


-- 
~Randy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin <linsh@oregonstate.edu> - 2017-03-31 23:00 +0200
  Re: [PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch  warning Randy Dunlap <rdunlap@infradead.org> - 2017-04-01 00:00 +0200

csiph-web