Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614825

Re: [PATCH] phy/ethtool: Add missing SPEED_<foo> strings

Show all headers | View raw

On Sun, 2017-04-02 at 23:40 +0200, Andrew Lunn wrote:
> On Sun, Apr 02, 2017 at 02:30:06PM -0700, Joe Perches wrote:
> > Add all the currently available SPEED_<foo> strings.
[]
> > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
[]
> > @@ -1487,6 +1487,7 @@ enum ethtool_link_mode_bit_indices {
> >   */
> >  
> >  /* The forced speed, in units of 1Mb. All values 0 to INT_MAX are legal. */
> 
> Hi Joe
> 
> Given that this list is getting longer and longer, and the comment
> that 0..INT_MAX are legal, is it time to replace this with something
> dynamic?

Hey Andrew.

Probably not.

INT_MAX in units of millions is likely large enough for
quite awhile yet, maybe 2 decades or even more.

If you feel ambitious, and remember ethtool.h and
SPEED_<foo> uses are a public API, write something up.

cheers, Joe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] phy/ethtool: Add missing SPEED_<foo> strings Joe Perches <joe@perches.com> - 2017-04-02 23:40 +0200
  Re: [PATCH] phy/ethtool: Add missing SPEED_<foo> strings Joe Perches <joe@perches.com> - 2017-04-02 23:50 +0200
  Re: [PATCH] phy/ethtool: Add missing SPEED_<foo> strings Andrew Lunn <andrew@lunn.ch> - 2017-04-02 23:50 +0200
  Re: [PATCH] phy/ethtool: Add missing SPEED_<foo> strings Florian Fainelli <f.fainelli@gmail.com> - 2017-04-03 00:40 +0200
    Re: [PATCH] phy/ethtool: Add missing SPEED_<foo> strings Joe Perches <joe@perches.com> - 2017-04-03 04:50 +0200
  Re: [PATCH] phy/ethtool: Add missing SPEED_<foo> strings David Miller <davem@davemloft.net> - 2017-04-05 15:50 +0200

csiph-web