Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1614759

Re: [PATCH v2 4/5] serial: split generic UART driver helper functions into a separate file

From Nicolas Pitre <nicolas.pitre@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 4/5] serial: split generic UART driver helper functions into a separate file
Date 2017-04-02 17:50 +0200
Message-ID <trPVn-2kD-5@gated-at.bofh.it> (permalink)
References <trzGW-gn-3@gated-at.bofh.it> <trzGW-gn-9@gated-at.bofh.it> <trNAd-VY-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, 2 Apr 2017, Andy Shevchenko wrote:

> On Sun, Apr 2, 2017 at 1:21 AM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> > This contains code that is common between serial_core.c and the
> > minitty code to come. Mainly helper functions used by UART drivers.
> 
> 
> I have two questions:
> - why minitty (what is that by the way?) can't use serial_core.c as a library?

See patch 5/5. It is a compatible replacement for serial_core.c and the 
entire TTY layer collapsed into the smallest code possible, and the 
result is itself smaller than serial_core.c alone.

> - does -M -C help to make this diff shorter?

No it doesn't. Maybe I should have mentioned that there is no functional 
change resulting from this patch.


Nicolas

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 4/5] serial: split generic UART driver helper functions into a separate file Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-04-02 00:30 +0200
  Re: [PATCH v2 4/5] serial: split generic UART driver helper functions  into a separate file Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-02 15:20 +0200
    Re: [PATCH v2 4/5] serial: split generic UART driver helper functions  into a separate file Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-04-02 17:50 +0200
  Re: [PATCH v2 4/5] serial: split generic UART driver helper  functions into a separate file kbuild test robot <lkp@intel.com> - 2017-04-03 09:40 +0200

csiph-web