Re: [RFC PATCH v2 4/4] ARM: sun8i: h3: add support for the thermal sensor in H3

From	Quentin Schulz <quentin.schulz@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v2 4/4] ARM: sun8i: h3: add support for the thermal sensor in H3
Date	2017-04-02 16:40 +0200
Message-ID	<trOPD-1F1-7@gated-at.bofh.it> (permalink)
References	<trO3f-16F-3@gated-at.bofh.it> <trO3f-16F-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Icenowy,

On 02/04/2017 15:33, Icenowy Zheng wrote:
> As we have gained the support for the thermal sensor in H3, we can now
> add its device nodes to the device tree.
> 
> Add them to the H3 device tree.
> 
> The H5 thermal sensor has some differences, and will be added furtherly.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  arch/arm/boot/dts/sun8i-h3.dtsi | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index b36f9f423c39..552217bb9266 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -72,6 +72,32 @@
>  		};
>  	};
>  
> +	iio-hwmon {
> +		compatible = "iio-hwmon";
> +		io-channels = <&ths>;
> +	};
> +
> +	soc {
> +		ths: ths@01c25000 {
> +			compatible = "allwinner,sun8i-h3-ths";
> +			reg = <0x01c25000 0x100>;
> +			clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>;
> +			clock-names = "bus", "ths";
> +			resets = <&ccu RST_BUS_THS>;
> +			#thermal-sensor-cells = <0>;
> +			#io-channel-cells = <0>;
> +		};
> +	};
> +
> +	thermal-zones {
> +		cpu_thermal {
> +			/* milliseconds */
> +			polling-delay-passive = <250>;
> +			polling-delay = <1000>;
> +			thermal-sensors = <&ths>;
> +		};

Would it make sense to add the CPU temp trip points in this patch? Or do
we wait to have CPU OPPs and thermal throttling to add them?

I guess you can find them either in the datasheet or in vendor tree.

Thanks,
Quentin

-- 
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

[RFC PATCH v2 4/4] ARM: sun8i: h3: add support for the thermal sensor in H3 Icenowy Zheng <icenowy@aosc.io> - 2017-04-02 15:50 +0200
  Re: [RFC PATCH v2 4/4] ARM: sun8i: h3: add support for the thermal  sensor in H3 Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-04-02 16:40 +0200
    Re: [RFC PATCH v2 4/4] ARM: sun8i: h3: add support for the thermal  sensor in H3 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-03 08:50 +0200

csiph-web