Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614186

[PATCH 1/8] Documentation/filesystems: fix documentation for ->getattr()

Show all headers | View raw

From: Eric Biggers <ebiggers@google.com>

Following the recent merge of statx, correct the documented prototype
for the ->getattr() inode operation, and add an entry to the porting
file.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 Documentation/filesystems/Locking |    3 +--
 Documentation/filesystems/porting |    6 ++++++
 Documentation/filesystems/vfs.txt |    3 +--
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/Documentation/filesystems/Locking b/Documentation/filesystems/Locking
index fdcfdd79682a..fe25787ff6d4 100644
--- a/Documentation/filesystems/Locking
+++ b/Documentation/filesystems/Locking
@@ -58,8 +58,7 @@ prototypes:
 	int (*permission) (struct inode *, int, unsigned int);
 	int (*get_acl)(struct inode *, int);
 	int (*setattr) (struct dentry *, struct iattr *);
-	int (*getattr) (const struct path *, struct dentry *, struct kstat *,
-			u32, unsigned int);
+	int (*getattr) (const struct path *, struct kstat *, u32, unsigned int);
 	ssize_t (*listxattr) (struct dentry *, char *, size_t);
 	int (*fiemap)(struct inode *, struct fiemap_extent_info *, u64 start, u64 len);
 	void (*update_time)(struct inode *, struct timespec *, int);
diff --git a/Documentation/filesystems/porting b/Documentation/filesystems/porting
index 95280079c0b3..5fb17f49f7a2 100644
--- a/Documentation/filesystems/porting
+++ b/Documentation/filesystems/porting
@@ -600,3 +600,9 @@ in your dentry operations instead.
 [recommended]
 	->readlink is optional for symlinks.  Don't set, unless filesystem needs
 	to fake something for readlink(2).
+--
+[mandatory]
+	->getattr() is now passed a struct path rather than a vfsmount and
+	dentry separately, and it now has request_mask and query_flags arguments
+	to specify the fields and sync type requested by statx.  Filesystems not
+	supporting any statx-specific features may ignore the new arguments.
diff --git a/Documentation/filesystems/vfs.txt b/Documentation/filesystems/vfs.txt
index 569211703721..94dd27ef4a76 100644
--- a/Documentation/filesystems/vfs.txt
+++ b/Documentation/filesystems/vfs.txt
@@ -382,8 +382,7 @@ struct inode_operations {
 	int (*permission) (struct inode *, int);
 	int (*get_acl)(struct inode *, int);
 	int (*setattr) (struct dentry *, struct iattr *);
-	int (*getattr) (const struct path *, struct dentry *, struct kstat *,
-			u32, unsigned int);
+	int (*getattr) (const struct path *, struct kstat *, u32, unsigned int);
 	ssize_t (*listxattr) (struct dentry *, char *, size_t);
 	void (*update_time)(struct inode *, struct timespec *, int);
 	int (*atomic_open)(struct inode *, struct dentry *, struct file *,

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/8] Documentation/filesystems: fix documentation for  ->getattr() David Howells <dhowells@redhat.com> - 2017-03-31 19:40 +0200
  [PATCH 8/8] statx: Include a mask for stx_attributes in struct statx David Howells <dhowells@redhat.com> - 2017-03-31 19:40 +0200
    Re: [PATCH 8/8] statx: Include a mask for stx_attributes in struct  statx "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-03-31 19:50 +0200
    Re: [PATCH 8/8] statx: Include a mask for stx_attributes in struct  statx Christoph Hellwig <hch@infradead.org> - 2017-04-04 09:20 +0200
  [PATCH 7/8] statx: Reserve the top bit of the mask for future  struct expansion David Howells <dhowells@redhat.com> - 2017-03-31 19:40 +0200
  [PATCH 5/8] ext4: Add statx support David Howells <dhowells@redhat.com> - 2017-03-31 19:40 +0200
  [PATCH 2/8] statx: reject unknown flags when using NULL path David Howells <dhowells@redhat.com> - 2017-03-31 19:40 +0200
  [PATCH 4/8] statx: optimize copy of struct statx to userspace David Howells <dhowells@redhat.com> - 2017-03-31 19:40 +0200

csiph-web