RE: [PATCH V2 net-next 18/18] net: hns: Some checkpatch.pl script & warning fixes

From	Salil Mehta <salil.mehta@huawei.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH V2 net-next 18/18] net: hns: Some checkpatch.pl script & warning fixes
Date	2017-03-31 18:50 +0200
Message-ID	<tr7Um-76y-25@gated-at.bofh.it> (permalink)
References	<tr2UF-3Xe-3@gated-at.bofh.it> <tr2UF-3Xe-19@gated-at.bofh.it> <tr6Yh-6ua-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Friday, March 31, 2017 4:45 PM
> To: Salil Mehta; davem@davemloft.net
> Cc: Zhuangyuzeng (Yisen); mehta.salil.lnk@gmail.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm
> Subject: Re: [PATCH V2 net-next 18/18] net: hns: Some checkpatch.pl
> script & warning fixes
> 
> On Fri, 2017-03-31 at 12:20 +0100, Salil Mehta wrote:
> > This patch fixes some checkpatch.pl script caught errors and
> > warnings during the compilation time.
> []
> > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> []
> > @@ -512,7 +512,8 @@ static void hns_nic_reuse_page(struct sk_buff
> *skb, int i,
> >  	int last_offset;
> >  	bool twobufs;
> >
> > -	twobufs = ((PAGE_SIZE < 8192) && hnae_buf_size(ring) ==
> HNS_BUFFER_SIZE_2048);
> > +	twobufs = ((PAGE_SIZE < 8192) && hnae_buf_size(ring)
> > +			== HNS_BUFFER_SIZE_2048);
> 
> This would read nicer without splitting a comparison test
> onto multiple lines
> 
> 	twobufs = PAGE_SIZE < 8192 &&
> 		  hnae_buf_size(ring) == HNS_BUFFER_SIZE_2048;
For sure, thanks for noticing. Will correct this!

Best regards
Salil
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2 net-next 18/18] net: hns: Some checkpatch.pl script & warning fixes Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 13:30 +0200
  Re: [PATCH V2 net-next 18/18] net: hns: Some checkpatch.pl script &  warning fixes Joe Perches <joe@perches.com> - 2017-03-31 17:50 +0200
    RE: [PATCH V2 net-next 18/18] net: hns: Some checkpatch.pl script &  warning fixes Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 18:50 +0200

csiph-web