Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614043

Re: [PATCH 2/3] dt-bindings: arm: amlogic: Add SoC information bindings

Show all headers | View raw

On Fri, Mar 31, 2017 at 10:47 AM, Neil Armstrong
<narmstrong@baylibre.com> wrote:
> Add bindings for the SoC information register of the Amlogic SoCs.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  Documentation/devicetree/bindings/arm/amlogic.txt | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt
> index bfd5b55..b850985 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.txt
> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt
> @@ -52,3 +52,23 @@ Board compatible values:
>    - "amlogic,q201" (Meson gxm s912)
>    - "nexbox,a95x" (Meson gxbb or Meson gxl s905x)
>    - "nexbox,a1" (Meson gxm s912)
> +
> +Amlogic Meson GX SoCs Information
> +----------------------------------
> +
> +The Meson SoCs have a Product Register that allows to retrieve SoC type,
> +package and revision information. If present, a device node for this register
> +should be added.
> +
> +Required properties:
> +  - compatible: For Meson GX SoCs, must be "amlogic,meson-gx-socinfo".
> +  - reg: Base address and length of the register block.
> +
> +Examples
> +--------
> +
> +       chipid@220 {
> +               compatible = "amlogic,meson-gx-socinfo";
> +               reg = <0x0 0x00220 0x0 0x4>;
> +       };
> +

The register location would hint that this is in the middle of some block of
random registers, i.e. a syscon or some unrelated device.

Are you sure that "socinfo" is the actual name of the IP block and that
it only has a single 32-bit register?

     Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] soc: amlogic: Add Amlogic SoC Information driver Neil Armstrong <narmstrong@baylibre.com> - 2017-03-31 10:50 +0200
  [PATCH 2/3] dt-bindings: arm: amlogic: Add SoC information bindings Neil Armstrong <narmstrong@baylibre.com> - 2017-03-31 10:50 +0200
    Re: [PATCH 2/3] dt-bindings: arm: amlogic: Add SoC information bindings Arnd Bergmann <arnd@arndb.de> - 2017-03-31 15:50 +0200
      Re: [PATCH 2/3] dt-bindings: arm: amlogic: Add SoC information  bindings Neil Armstrong <narmstrong@baylibre.com> - 2017-03-31 16:20 +0200
        Re: [PATCH 2/3] dt-bindings: arm: amlogic: Add SoC information  bindings Rob Herring <robh@kernel.org> - 2017-04-03 18:40 +0200
          Re: [PATCH 2/3] dt-bindings: arm: amlogic: Add SoC information  bindings Neil Armstrong <narmstrong@baylibre.com> - 2017-04-04 11:00 +0200
            Re: [PATCH 2/3] dt-bindings: arm: amlogic: Add SoC information bindings Rob Herring <robh@kernel.org> - 2017-04-04 14:30 +0200
              Re: [PATCH 2/3] dt-bindings: arm: amlogic: Add SoC information  bindings Neil Armstrong <narmstrong@baylibre.com> - 2017-04-04 14:50 +0200
                Re: [PATCH 2/3] dt-bindings: arm: amlogic: Add SoC information bindings Rob Herring <robh@kernel.org> - 2017-04-05 21:20 +0200

csiph-web