Re: [PATCH 2/2] kvm: make KVM_COALESCED_MMIO_PAGE_OFFSET public

From	Radim Krčmář <rkrcmar@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] kvm: make KVM_COALESCED_MMIO_PAGE_OFFSET public
Date	2017-03-31 15:40 +0200
Message-ID	<tr4Wv-5cZ-37@gated-at.bofh.it> (permalink)
References	<tr3nI-497-7@gated-at.bofh.it> <tr3nI-497-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2017-03-31 13:53+0200, Paolo Bonzini:
> Its value has never changed; we might as well make it part of the ABI instead
> of using the return value of KVM_CHECK_EXTENSION(KVM_CAP_COALESCED_MMIO).
> 
> Because PPC does not always make MMIO available, the code has to be made
> dependent on CONFIG_KVM_MMIO rather than KVM_COALESCED_MMIO_PAGE_OFFSET.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---

I like the change to CONFIG_KVM_MMIO and the interface isn't suited for
dynamic offsets based on enabled features anyway ...

Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] kvm: API adjustments for dirty page ring patches Paolo Bonzini <pbonzini@redhat.com> - 2017-03-31 14:00 +0200
  [PATCH 1/2] kvm: make KVM_CAP_COALESCED_MMIO architecture agnostic Paolo Bonzini <pbonzini@redhat.com> - 2017-03-31 14:00 +0200
    Re: [PATCH 1/2] kvm: make KVM_CAP_COALESCED_MMIO architecture  agnostic Radim Krčmář <rkrcmar@redhat.com> - 2017-03-31 15:30 +0200
    Re: [PATCH 1/2] kvm: make KVM_CAP_COALESCED_MMIO architecture  agnostic Radim Krčmář <rkrcmar@redhat.com> - 2017-03-31 15:50 +0200
      Re: [PATCH 1/2] kvm: make KVM_CAP_COALESCED_MMIO architecture  agnostic David Hildenbrand <david@redhat.com> - 2017-04-03 13:30 +0200
  [PATCH 2/2] kvm: make KVM_COALESCED_MMIO_PAGE_OFFSET public Paolo Bonzini <pbonzini@redhat.com> - 2017-03-31 14:00 +0200
    Re: [PATCH 2/2] kvm: make KVM_COALESCED_MMIO_PAGE_OFFSET public Radim Krčmář <rkrcmar@redhat.com> - 2017-03-31 15:40 +0200

csiph-web