Re: [Intel-gfx] [PATCH] drm/i915: use static const array for PICK macro

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [Intel-gfx] [PATCH] drm/i915: use static const array for PICK macro
Date	2017-03-31 15:40 +0200
Message-ID	<tr4Wu-5cZ-19@gated-at.bofh.it> (permalink)
References	<tndvk-2mG-21@gated-at.bofh.it> <tnnkZ-EB-5@gated-at.bofh.it> <tnnEm-OE-23@gated-at.bofh.it> <tnpmO-24D-23@gated-at.bofh.it> <tnq9b-2CM-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 21, 2017 at 12:23 PM, Jani Nikula
<jani.nikula@linux.intel.com> wrote:
> On Tue, 21 Mar 2017, Daniel Vetter <daniel@ffwll.ch> wrote:
>> On Tue, Mar 21, 2017 at 09:44:07AM +0100, Arnd Bergmann wrote:
> Arnd, can you check that with kasan please? (I don't have gcc 7.) For me
> the size diff against current git is
>
>     text           data     bss     dec     hex filename
> -1137236          31211    2948 1171395  11dfc3 drivers/gpu/drm/i915/i915.ko
> +1139702          31211    2948 1173861  11e965 drivers/gpu/drm/i915/i915.ko

Sorry for the late reply.

I was rather sure that I had done the numbers and replied to you earlier, but
I see no evidence of that, so here it comes again, using gcc-7 and kasan:

   text   data    bss    dec    hex filename
2623339 511153  12064 3146556 30033c
obj-x86/drivers/gpu/drm/i915/i915-original.o
2634886 511153  12064 3158103 303057
obj-x86/drivers/gpu/drm/i915/i915-linux-next.o
2617989 520561  12064 3150614 301316
obj-x86/drivers/gpu/drm/i915/i915-arndpatch.o

The first one is linux-next with ce64645d86ac ("drm/i915: use variadic macros
and arrays to choose port/pipe based registers") reverted, the second one is
the current version, and the third is with my patch applied on top.

       Arnd

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [Intel-gfx] [PATCH] drm/i915: use static const array for PICK macro Arnd Bergmann <arnd@arndb.de> - 2017-03-31 15:40 +0200

csiph-web