Re: [PATCH] serial: tegra: Map the iir register to default defines

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] serial: tegra: Map the iir register to default defines
Date	Fri, 31 Mar 2017 15:30:03 +0200
Message-ID	<tr4MP-59K-33@gated-at.bofh.it> (permalink)
References	<tqqPn-2sY-1@gated-at.bofh.it> <tqICC-74s-17@gated-at.bofh.it> <tqKl5-8nZ-69@gated-at.bofh.it>
X-Original-To	Olliver Schinagl <oliver@schinagl.nl>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.8.0 (2017-02-23)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	Jon Hunter <jonathanh@nvidia.com>, Laxman Dewangan <ldewangan@nvidia.com>, Jiri Slaby <jslaby@suse.com>, Stephen Warren <swarren@wwwdotorg.org>, Thierry Reding <thierry.reding@gmail.com>, Alexandre Courbot <gnurou@gmail.com>, linux-serial@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 31 Mar 2017 15:21:37 +0200
X-Original-Message-ID	<20170331132137.GA23510@kroah.com>
X-Original-References	<20170329184806.6577-1-oliver@schinagl.nl> <9eed3c8e-a7af-1e1f-659a-a092a89d1679@nvidia.com> <0DEBCDAD-C7D3-4DB9-B5F5-408951165662@schinagl.nl>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1614030

Show key headers only | View raw

On Thu, Mar 30, 2017 at 05:37:41PM +0200, Olliver Schinagl wrote:
> Hey Jon,
> 
> On March 30, 2017 3:42:19 PM CEST, Jon Hunter <jonathanh@nvidia.com> wrote:
> >
> >On 29/03/17 19:48, Olliver Schinagl wrote:
> >> The tegra serial IP seems to be following the common layout and the
> >> interrupt ID's match up nicely. Replace the magic values to match the
> >> common serial_reg defines, with the addition of the Tegra unique End
> >of
> >> Data interrupt.
> >> 
> >> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> >> ---
> >> Note I do not own any tegra hardware and just noticed it while
> >working on my
> >> somewhat related previous patch,
> >> "serial: Do not treat the IIR register as a bitfield"
> >> 
> >> As such, this patch can only be applied after the aforementioned
> >patch or the
> >> iir variable will not have its mask applied yet.
> >
> >Nit-pick. If this is the case, then this should really be part of a
> >patch series so it is obvious to everyone that this should only be
> >applied after the other patch.
> Yes, and it was, but I did not want to have the really big list of names in this much smaller group.

Ok, this is a mess, don't send me patches that need to be applied in a
specific order, yet are not obviously linked together in a single
series.

How do you expect a maintainer to handle this type of stuff?  You need
to make it _OBVIOUS_ as to what I need to do here, otherwise I will get
it wrong.

I'm going to drop all of your patches from my queue and wait for a
resend with the correct order, and ones that work properly, you can do
better than this :)

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] serial: tegra: Map the iir register to default defines Olliver Schinagl <oliver@schinagl.nl> - 2017-03-29 20:50 +0200
  Re: [PATCH] serial: tegra: Map the iir register to default defines Laxman Dewangan <ldewangan@nvidia.com> - 2017-03-30 12:40 +0200
    RE: [PATCH] serial: tegra: Map the iir register to default defines Shardar Mohammed <smohammed@nvidia.com> - 2017-03-31 12:10 +0200
      Re: [PATCH] serial: tegra: Map the iir register to default defines Jon Hunter <jonathanh@nvidia.com> - 2017-03-31 12:30 +0200
        RE: [PATCH] serial: tegra: Map the iir register to default defines Shardar Mohammed <smohammed@nvidia.com> - 2017-03-31 12:50 +0200
          Re: [PATCH] serial: tegra: Map the iir register to default defines Olliver Schinagl <o.schinagl@ultimaker.com> - 2017-03-31 13:40 +0200
  Re: [PATCH] serial: tegra: Map the iir register to default defines Jon Hunter <jonathanh@nvidia.com> - 2017-03-30 15:50 +0200
    Re: [PATCH] serial: tegra: Map the iir register to default defines Olliver Schinagl <oliver@schinagl.nl> - 2017-03-30 17:40 +0200
      Re: [PATCH] serial: tegra: Map the iir register to default defines Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-31 15:30 +0200

csiph-web