Re: [PATCH] i2c: designware: Get selected speed mode sda-hold-time via ACPI

From	Jarkko Nikula <jarkko.nikula@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] i2c: designware: Get selected speed mode sda-hold-time via ACPI
Date	2017-03-31 14:20 +0200
Message-ID	<tr3H4-4uB-23@gated-at.bofh.it> (permalink)
References	<tpUZb-4Zu-3@gated-at.bofh.it> <tpUZb-4Zu-1@gated-at.bofh.it> <tpVBT-5sY-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/28/2017 12:13 PM, Andy Shevchenko wrote:
> On Tue, 2017-03-28 at 16:48 +0800, Tan Chin Yew wrote:
>> Sda-hold-time is an important parameter for tuning i2c to meet the
>> electrical specification especially for high speed. I2C with incorrect
>> sda-hold-time may cause lost arbitration error. Instead of loading all
>> speed mode settings, only selected speed mode settings are loaded.
>>
>> Signed-off-by: Tan Chin Yew <chin.yew.tan@intel.com>
>
>
> Looks good to me:
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] i2c: designware: Get selected speed mode sda-hold-time via ACPI Tan Chin Yew <chin.yew.tan@intel.com> - 2017-03-28 10:50 +0200
  Re: [PATCH] i2c: designware: Get selected speed mode sda-hold-time  via ACPI Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-28 11:30 +0200
    Re: [PATCH] i2c: designware: Get selected speed mode sda-hold-time  via ACPI Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-03-31 14:20 +0200

csiph-web