[PATCH V2 net-next 04/18] net: hns: Remove redundant memset during buffer release

Path	csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Salil Mehta <salil.mehta@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH V2 net-next 04/18] net: hns: Remove redundant memset during buffer release
Date	Fri, 31 Mar 2017 13:30:02 +0200
Message-ID	<tr2UG-3Xe-33@gated-at.bofh.it> (permalink)
References	<tr2UF-3Xe-3@gated-at.bofh.it>
X-Mailer	git-send-email 2.8.3
MIME-Version	1.0
Content-Type	text/plain
X-Originating-IP	[10.203.181.152]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A020205.58DE3BCB.01A1,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	e21f306b1703e4022b026af9733d23e5
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	<salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>, <mehta.salil.lnk@gmail.com>, <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>, lipeng <lipeng321@huawei.com>, Weiwei Deng <dengweiwei@huawei.com>
X-Original-Date	Fri, 31 Mar 2017 12:20:18 +0100
X-Original-Message-ID	<20170331112032.4692-5-salil.mehta@huawei.com>
X-Original-References	<20170331112032.4692-1-salil.mehta@huawei.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1613895

Show key headers only | View raw

From: lipeng <lipeng321@huawei.com>

Because all members of desc_cb is assigned when xmit one package, so it
can delete in hnae_free_buffer, as follows:
        - "dma, priv, length, type" are assigned in fill_v2_desc.
        - "page_offset, reuse_flag, buf" are not used in tx direction.

Signed-off-by: lipeng <lipeng321@huawei.com>
Signed-off-by: Weiwei Deng <dengweiwei@huawei.com>
Reviewed-by: Yisen Zhuang <yisen.zhuang@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
---
 drivers/net/ethernet/hisilicon/hns/hnae.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/drivers/net/ethernet/hisilicon/hns/hnae.c
index b6ed818..78af663 100644
--- a/drivers/net/ethernet/hisilicon/hns/hnae.c
+++ b/drivers/net/ethernet/hisilicon/hns/hnae.c
@@ -61,7 +61,6 @@ static void hnae_free_buffer(struct hnae_ring *ring, struct hnae_desc_cb *cb)
 		dev_kfree_skb_any((struct sk_buff *)cb->priv);
 	else if (unlikely(is_rx_ring(ring)))
 		put_page((struct page *)cb->priv);
-	memset(cb, 0, sizeof(*cb));
 }
 
 static int hnae_map_buffer(struct hnae_ring *ring, struct hnae_desc_cb *cb)
-- 
2.7.4

Thread

[PATCH V2 net-next 00/18] net: hns: Misc. HNS Bug Fixes & Code Improvements Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 13:30 +0200
  [PATCH V2 net-next 02/18] net: hns: Modify GMAC init TX threshold value Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 13:30 +0200
  [PATCH V2 net-next 15/18] net: hns: Simplify the exception sequence in hns_ppe_init() Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 13:30 +0200
  [PATCH V2 net-next 17/18] net: hns: Avoid Hip06 chip TX packet line bug Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 13:30 +0200
  [PATCH V2 net-next 09/18] net: hns: Correct HNS RSS key set function Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 13:30 +0200
  [PATCH V2 net-next 04/18] net: hns: Remove redundant memset during buffer release Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 13:30 +0200
  [PATCH V2 net-next 16/18] net: hns: Adjust the SBM module buffer threshold Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 13:30 +0200
  [PATCH V2 net-next 07/18] net: hns: Fix to adjust buf_size of ring according to mtu Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 13:30 +0200
  [PATCH V2 net-next 14/18] net: hns: Optimise the code in hns_mdio_wait_ready() Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 13:30 +0200
  [PATCH V2 net-next 11/18] net: hns: Remove redundant mac_get_id() Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 13:30 +0200

csiph-web