Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1613875

Re: [PATCH v5 2/2] mmc: host: s3cmci: allow probing from device tree

Show all headers | View raw

On 31 March 2017 at 09:25, Arnd Bergmann <arnd@arndb.de> wrote:
> On Sat, Mar 18, 2017 at 2:13 AM, Sergio Prado
> <sergio.prado@e-labworks.com> wrote:
>
>>
>> +static const struct of_device_id s3cmci_dt_match[] = {
>> +       {
>> +               .compatible = "samsung,s3c2410-sdi",
>> +               .data = (void *)0,
>> +       },
>> +       {
>> +               .compatible = "samsung,s3c2412-sdi",
>> +               .data = (void *)1,
>> +       },
>> +       {
>> +               .compatible = "samsung,s3c2440-sdi",
>> +               .data = (void *)1,
>> +       },
>> +       { /* sentinel */ },
>> +};
>> +MODULE_DEVICE_TABLE(of, sdhci_s3c_dt_match);
>> +
>
> The names don't match:
>
> In file included from /git/arm-soc/drivers/mmc/host/s3cmci.c:14:0:
> /git/arm-soc/drivers/mmc/host/s3cmci.c:1844:25: error:
> 'sdhci_s3c_dt_match' undeclared here (not in a function); did you mean
> 's3cmci_dt_match'?
>  MODULE_DEVICE_TABLE(of, sdhci_s3c_dt_match);
>                          ^
> /git/arm-soc/include/linux/module.h:212:21: note: in definition of
> macro 'MODULE_DEVICE_TABLE'
>  extern const typeof(name) __mod_##type##__##name##_device_table  \
>                      ^~~~
> /git/arm-soc/include/linux/module.h:212:27: error:
> '__mod_of__sdhci_s3c_dt_match_device_table' aliased to undefined
> symbol 'sdhci_s3c_dt_match'
>  extern const typeof(name) __mod_##type##__##name##_device_table  \
>                            ^
> /git/arm-soc/drivers/mmc/host/s3cmci.c:1844:1: note: in expansion of
> macro 'MODULE_DEVICE_TABLE'
>  MODULE_DEVICE_TABLE(of, sdhci_s3c_dt_match);
>  ^~~~~~~~~~~~~~~~~~~
> /git/arm-soc/scripts/Makefile.build:314: recipe for target
> 'drivers/mmc/host/s3cmci.o' failed
>
> Can you send a fix?

Never mind, I am dropping the patches from my next branch as those
clearly haven't been built/tested by Sergio properly. It's better that
he re-spins them.

Arnd, thanks for reporting and even fixing some of the problems!

Kind regards
Uffe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 2/2] mmc: host: s3cmci: allow probing from device tree Arnd Bergmann <arnd@arndb.de> - 2017-03-31 09:30 +0200
  Re: [PATCH v5 2/2] mmc: host: s3cmci: allow probing from device tree Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-31 13:20 +0200
    Re: [PATCH v5 2/2] mmc: host: s3cmci: allow probing from device tree Sergio Prado <sergio.prado@e-labworks.com> - 2017-04-01 00:50 +0200

csiph-web