Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES

From	Cao jin <caoj.fnst@cn.fujitsu.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES
Date	2017-03-30 05:30 +0200
Message-ID	<tqyWD-5f-25@gated-at.bofh.it> (permalink)
References	<tpUFP-4R5-3@gated-at.bofh.it> <tq1R0-1HW-35@gated-at.bofh.it> <tqbwZ-hk-9@gated-at.bofh.it> <tqnHQ-lp-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 03/29/2017 11:28 PM, Tejun Heo wrote:
> On Wed, Mar 29, 2017 at 10:38:17AM +0800, Cao jin wrote:
>> On 03/29/2017 12:00 AM, Tejun Heo wrote:
>>> On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote:
>>>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>>>
>>> I'm not sure.  I think I used it during development and it's not like
>>> it costs anything to keep.
>>
>> It easily confusing newbies without any comments for its purpose.
> 
> percpu variable handling is pretty complex to begin with.  I don't buy
> that an empty default attribute macro adds anything noticeable there.
> 
>> Temporary using during development seems not good to persist. Could I
>> know its purpose?
> 
> I don't remember the exact details but at the same time I don't see
> the value of the proposed change.  We can apply or not apply the patch
> and either way wouldn't make any noticeable difference.  What's the
> point?
> 
> Thanks.
> 

It doesn't matter whether apply or not. I just start to read these code
and want to know what every tiny symbol is for.  Thanks for your time.
-- 
Sincerely,
Cao jin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-03-28 10:30 +0200
  Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES Tejun Heo <tj@kernel.org> - 2017-03-28 18:10 +0200
    Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-03-29 04:30 +0200
      Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES Tejun Heo <tj@kernel.org> - 2017-03-29 17:30 +0200
        Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-03-30 05:30 +0200

csiph-web