Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1612386

Re: [PATCH] ezchip: nps_enet: check if napi has been completed

Show all headers | View raw

From: Vlad Zakharov <Vladislav.Zakharov@synopsys.com>
Date: Wed, 29 Mar 2017 13:41:46 +0300

> After a new NAPI_STATE_MISSED state was added to NAPI we can get into
> this state and in such case we have to reschedule NAPI as some work is
> still pending and we have to process it. napi_complete_done() function
> returns false if we have to reschedule something (e.g. in case we were
> in MISSED state) as current polling have not been completed yet.
> 
> nps_enet driver hasn't been verifying the return value of
> napi_complete_done() and has been forcibly enabling interrupts. That is
> not correct as we should not enable interrupts before we have processed
> all scheduled work. As a result we were getting trapped in interrupt
> hanlder chain as we had never been able to disabale ethernet
> interrupts again.
> 
> So this patch makes nps_enet_poll() func verify return value of
> napi_complete_done() and enable interrupts only in case all scheduled
> work has been completed.
> 
> Signed-off-by: Vlad Zakharov <vzakhar@synopsys.com>

Applied.

Eric, if this is really required now, we have 148 broken drivers still.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ezchip: nps_enet: check if napi has been completed Vlad Zakharov <Vladislav.Zakharov@synopsys.com> - 2017-03-29 12:50 +0200
  Re: [PATCH] ezchip: nps_enet: check if napi has been completed Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-29 17:00 +0200
  Re: [PATCH] ezchip: nps_enet: check if napi has been completed David Miller <davem@davemloft.net> - 2017-03-29 23:40 +0200
    Re: [PATCH] ezchip: nps_enet: check if napi has been completed Eric Dumazet <edumazet@google.com> - 2017-03-29 23:50 +0200
      Re: [PATCH] ezchip: nps_enet: check if napi has been completed Vlad Zakharov <Vladislav.Zakharov@synopsys.com> - 2017-03-30 11:20 +0200
        Re: [PATCH] ezchip: nps_enet: check if napi has been completed Eric Dumazet <edumazet@google.com> - 2017-03-30 15:30 +0200

csiph-web