Re: [RFC PATCH 4/5] sched/events: Introduce sched_entity load tracking trace event

From	Dietmar Eggemann <dietmar.eggemann@arm.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 4/5] sched/events: Introduce sched_entity load tracking trace event
Date	2017-03-29 22:30 +0200
Message-ID	<tqso9-3FE-5@gated-at.bofh.it> (permalink)
References	<tpSXo-3CJ-11@gated-at.bofh.it> <tpSXo-3CJ-25@gated-at.bofh.it> <tpUmu-4GO-25@gated-at.bofh.it> <tq08z-pa-43@gated-at.bofh.it> <tq2tI-1Yg-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/28/2017 06:41 PM, Peter Zijlstra wrote:
> On Tue, Mar 28, 2017 at 04:13:45PM +0200, Dietmar Eggemann wrote:
>
>> Do you think that making them public in include/linux/sched.h is the way to
>> go?
>
> No; all that stuff should really stay private. tracepoints are a very
> bad reason to leak this stuff.

Understood & makes sense to me. In hindsight, it's not too complicated 
to code group_cfs_rq in include/trace/events/sched.h.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 4/5] sched/events: Introduce sched_entity load tracking trace event Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-03-28 08:40 +0200
  Re: [RFC PATCH 4/5] sched/events: Introduce sched_entity load  tracking trace event Peter Zijlstra <peterz@infradead.org> - 2017-03-28 10:10 +0200
    Re: [RFC PATCH 4/5] sched/events: Introduce sched_entity load  tracking trace event Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-03-28 16:10 +0200
    Re: [RFC PATCH 4/5] sched/events: Introduce sched_entity load  tracking trace event Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-03-28 16:20 +0200
  Re: [RFC PATCH 4/5] sched/events: Introduce sched_entity load  tracking trace event Peter Zijlstra <peterz@infradead.org> - 2017-03-28 10:10 +0200
    Re: [RFC PATCH 4/5] sched/events: Introduce sched_entity load  tracking trace event Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-03-28 16:20 +0200
      Re: [RFC PATCH 4/5] sched/events: Introduce sched_entity load  tracking trace event Peter Zijlstra <peterz@infradead.org> - 2017-03-28 18:50 +0200
        Re: [RFC PATCH 4/5] sched/events: Introduce sched_entity load  tracking trace event Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-03-29 22:30 +0200

csiph-web