Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1612272

Re: security/keys: add CONFIG_KEYS_COMPAT to Kconfig

Show all headers | View raw

On Thu,  9 Feb 2017 22:11:38 +0100, Bilal Amarni wrote:
> CONFIG_KEYS_COMPAT is defined in arch-specific Kconfigs and is missing for
> several 64-bit architectures : arm64, mips, parisc, tile.
> 
> At the moment and for those architectures, calling in 32-bit userspace the
> keyctl syscall would return an ENOSYS error.
> 
> This patch moves the CONFIG_KEYS_COMPAT option to security/keys/Kconfig, to
> make sure the compatibility wrapper is registered by default for any 64-bit
> architecture as long as it is configured with CONFIG_COMPAT.

David, where can I find the git branch this patch was applied to?  I don't see
it anywhere in security-keys or linux-security.

I recently added KEYS_COMPAT to arm64 (5c2a625937ba); that should be reverted
after this patch.

Also, I'd like to submit a follow-on patch that removes KEYS_COMPAT and simply
uses COMPAT.

And the parisc architecture doesn't use compat_sys_keyctl() in its compat
syscall table, so that should be fixed too (though that's not a new bug).

- Eric

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: security/keys: add CONFIG_KEYS_COMPAT to Kconfig Eric Biggers <ebiggers3@gmail.com> - 2017-03-29 21:30 +0200

csiph-web