Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1612155

Re: syscall_get_error() && TS_ checks

From Oleg Nesterov <oleg@redhat.com>
Newsgroups linux.kernel
Subject Re: syscall_get_error() && TS_ checks
Date 2017-03-29 19:10 +0200
Message-ID <tqpgB-1u5-1@gated-at.bofh.it> (permalink)
References <tq0UV-12M-15@gated-at.bofh.it> <tqoNA-14j-19@gated-at.bofh.it> <tqoXf-188-15@gated-at.bofh.it> <tqp6V-1bC-15@gated-at.bofh.it> <tqpgB-1u5-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 03/29, Linus Torvalds wrote:
>
> On Wed, Mar 29, 2017 at 9:55 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > Once again, it is only used in arch/x86/kernel/signal.c by do_signal() and
> > handle_signal(). We do not care if mmap() returns a valid pointer with the
> > high bit set, regs-ax can't be confused with -ERESTART code.
>
> Immaterial. If the function is called "get_error()", it sure as hell
> shouldn't return a random non-error value.

Oh, I agree, and let me repeat the 3rd time that I suggest to kill this
helper and use syscall_get_return_value() in arch/x86/kernel/signal.c,
it has no other callers.

Oleg.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/1] get_nr_restart_syscall() should return  __NR_ia32_restart_syscall if __USER32_CS Oleg Nesterov <oleg@redhat.com> - 2017-03-28 17:10 +0200
  syscall_get_error() && TS_ checks Oleg Nesterov <oleg@redhat.com> - 2017-03-29 18:40 +0200
    Re: syscall_get_error() && TS_ checks Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-29 18:50 +0200
      Re: syscall_get_error() && TS_ checks Oleg Nesterov <oleg@redhat.com> - 2017-03-29 19:00 +0200
        Re: syscall_get_error() && TS_ checks Oleg Nesterov <oleg@redhat.com> - 2017-03-29 19:10 +0200
          Re: syscall_get_error() && TS_ checks Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-29 19:20 +0200
            Re: syscall_get_error() && TS_ checks Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-29 21:00 +0200
              Re: syscall_get_error() && TS_ checks Oleg Nesterov <oleg@redhat.com> - 2017-03-30 16:00 +0200
                Re: syscall_get_error() && TS_ checks Oleg Nesterov <oleg@redhat.com> - 2017-03-30 18:00 +0200
                Re: syscall_get_error() && TS_ checks Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-30 19:50 +0200
                Re: syscall_get_error() && TS_ checks Andy Lutomirski <luto@amacapital.net> - 2017-03-30 20:30 +0200
                Re: syscall_get_error() && TS_ checks Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-30 20:40 +0200
                Re: syscall_get_error() && TS_ checks Andy Lutomirski <luto@amacapital.net> - 2017-03-30 21:00 +0200
                Re: syscall_get_error() && TS_ checks Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-30 21:20 +0200
                Re: syscall_get_error() && TS_ checks Andy Lutomirski <luto@amacapital.net> - 2017-03-30 21:30 +0200
                Re: syscall_get_error() && TS_ checks Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-30 21:30 +0200
            Re: syscall_get_error() && TS_ checks Oleg Nesterov <oleg@redhat.com> - 2017-03-29 21:00 +0200
        Re: syscall_get_error() && TS_ checks Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-29 19:10 +0200
      Re: syscall_get_error() && TS_ checks Andy Lutomirski <luto@amacapital.net> - 2017-03-29 19:10 +0200

csiph-web