Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1612123

[PATCH 1/2] Bluetooth: hci_bcm: add missing tty-device sanity check

Show all headers | View raw

Make sure to check the tty-device pointer before looking up the sibling
platform device to avoid dereferencing a NULL-pointer when the tty is
one end of a Unix98 pty.

Fixes: 0395ffc1ee05 ("Bluetooth: hci_bcm: Add PM for BCM devices")
Cc: stable <stable@vger.kernel.org>     # 4.3
Cc: Frederic Danis <frederic.danis@linux.intel.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/bluetooth/hci_bcm.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 5262a2077d7a..11f30e5cec2c 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -287,6 +287,9 @@ static int bcm_open(struct hci_uart *hu)
 
 	hu->priv = bcm;
 
+	if (!hu->tty->dev)
+		goto out;
+
 	mutex_lock(&bcm_device_lock);
 	list_for_each(p, &bcm_device_list) {
 		struct bcm_device *dev = list_entry(p, struct bcm_device, list);
@@ -307,7 +310,7 @@ static int bcm_open(struct hci_uart *hu)
 	}
 
 	mutex_unlock(&bcm_device_lock);
-
+out:
 	return 0;
 }
 
-- 
2.12.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Bluetooth: fix hci-uart crashes Johan Hovold <johan@kernel.org> - 2017-03-29 18:20 +0200
  [PATCH 2/2] Bluetooth: hci_intel: add missing tty-device sanity check Johan Hovold <johan@kernel.org> - 2017-03-29 18:20 +0200
  [PATCH 1/2] Bluetooth: hci_bcm: add missing tty-device sanity check Johan Hovold <johan@kernel.org> - 2017-03-29 18:20 +0200
  Re: [PATCH 0/2] Bluetooth: fix hci-uart crashes Marcel Holtmann <marcel@holtmann.org> - 2017-03-29 21:00 +0200

csiph-web